declare flatbuffers (imported but undeclared) + clean-install import smoke - #85
Open
tlebryk wants to merge 3 commits into
Open
declare flatbuffers (imported but undeclared) + clean-install import smoke#85tlebryk wants to merge 3 commits into
tlebryk wants to merge 3 commits into
Conversation
wsds imports `flatbuffers` across wsds/pupyarrow/flatbuf/*.py but never declared it. It's not transitive from the other declared deps (fastprogress/fire/numpy/polars/pyarrow/torch), so a clean `pip install .` + `import wsds` fails with ModuleNotFoundError: No module named 'flatbuffers'. It's been masked because dev/ML environments pull flatbuffers transitively (tensorflow/onnx/mediapipe/jax), but a minimal image (e.g. a clean vllm image) surfaces it. Fix: add flatbuffers to requirements.txt. Add an import-smoke CI that installs wsds fresh and imports it — the only check that catches an imported-but-undeclared dependency (pytest in a full env wouldn't). This CI fails on the pre-fix tree and passes with the declaration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wsds/pupyarrow/flatbuf/*.pyallimport flatbuffers, but it's declared nowhere in wsds and isn't transitive from the other declared deps. A cleanpip install .+import wsdsfails withModuleNotFoundError: No module named 'flatbuffers'atpupyarrow/flatbuf/Footer.py.Fail-to-pass proof (clean venv, wsds's declared deps only):