Improves tracking in Tedit windows, Tedit follows WHENOPERATEDONFN documentation - #2742
Merged
Merged
Conversation
Contributor
Author
|
Actually, I should have emphasized Tedit menu windows, that's where the testing focus should be. |
Member
|
My initial testing on Linux Mint 22.1 Cinnamon shows no issues. |
Member
|
Still looking good at commit 48a3775. |
…some time ago, this was missed
Member
|
Nothing unusual to report at commit 02b20b4. |
Member
|
Tested this PR relative to Issue#2734 (Notecards Document Card creation fails). This PR fixes that issue. Closing unmerged PR#2743, which had a similar fix to Issue#2734 in \TEDIT.INSTALL.PIECE. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily has to do with image objects in Tedit, and in particular the image objects in the Tedit windows.
As the mouse tracks overs the menu with the left/middle button held down, it now moves from object to object, showing what the next state of a new object will be and restoring the existing state of the prior object in the tracking. (With the current exception that if the mouse goes over the label of a type-in field, the tracking to future objects requires another click.) Essentially, the behavior of the menu objects has been moved from the WHENOPERATEDON-SELETED protocol to the BUTTONEVENTINFN.
The WHENOPERATEDON-SELECTED has been changed to honor the documentation. Previously, it would only apply the selected function if the selection contained just a single object. Now, if an extended selection contains several objects, the function of each object is applied. Thus the selection can be rejected if any object disallows it.