Fix traceback in threads when SetTrace used.#2075
Open
mickp wants to merge 1 commit into
Open
Conversation
Testing
===
The following script returns normamly, where previously it encountered: `ValueError: call stack is not deep enough`.
```
import sys
import threading
import typing
def tracer(frame, event, arg):
return tracer
def do_check():
isinstance(None, typing.Iterable)
sys.settrace(tracer)
t = threading.Thread(target=do_check)
t.start()
t.join()
```
Author
|
Resolves #2072 |
Author
Contributor
|
Thanks for the PR! Will be a couple weeks before I have time to properly look at this. |
Author
|
I think this addresses the root cause of the call stack loss in threads, but I can not figure out how the change is getting hit to cause that one test failure in all runtime targets. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Testing
The following script returns normamly, where previously it encountered:
ValueError: call stack is not deep enough.