Skip to content

ci: create the droid-reviewed label before adding it - #5

Merged
kingdomseed merged 14 commits into
mainfrom
claude/clever-meitner-iyop54
Oct 23, 2026
Merged

ci: create the droid-reviewed label before adding it#5
kingdomseed merged 14 commits into
mainfrom
claude/clever-meitner-iyop54

Conversation

@kingdomseed

@kingdomseed kingdomseed commented Oct 23, 2026 •
edited by blacksmith-sh Bot
Loading

Copy link
Copy Markdown
Contributor

GitHub's "Add labels to an issue" docs do not say a missing label is created, so the review workflow now creates droid-reviewed first and treats 422 (already exists) as success. Nothing else changes.

Checks: scripts/validate.py, unittest, node --test (104 pass).

Generated by Claude Code

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

claude added 14 commits October 23, 2026 10:07
@claude
ci: remove legacy Droid workflows
b9be8b1 
The legacy Droid Tag and Droid Auto Review workflows ran
Factory-AI/droid-action@main, unpinned, on every PR or @droid mention.
The opt-in factory-review and factory-mentions workflows replace them;
keeping both would give two reviews per PR and two replies per mention
once the replacements are enabled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
docs: drop the reusable review workflow from the README intro
9b498e4 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
Merge main into claude/clever-meitner-iyop54
6e1f73b
@claude
ci: review each PR once and refresh the wiki monthly
3c847c9 
Factory Review now runs when a PR opens ready for review or a draft is
marked ready, not on every push. A successful review adds the
droid-reviewed label, and a labelled PR is skipped; comment
`@droid review` to ask for another review. The review checks out the
live PR head, so a push between the event and the run is still covered.

Droid Wiki Refresh runs at 06:17 UTC on the 1st of each month instead of
on every push to main, and can still be started by hand.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
ci: create the droid-reviewed label and keep wiki runs on main
f1f9a13 
Adding a label that does not exist yet can fail, so the review job now
creates droid-reviewed when the repository lacks it. A manual wiki run
started from another branch would document unmerged code, so generation
runs only on the default branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
ci: restart an unlabelled review on push and label only the reviewed …
013c004 
…head

Without the synchronize trigger, a push during the first review left the
new commits labelled as reviewed but unseen. Pushes now cancel and restart
the review until the droid-reviewed label exists, and the label step skips
when the head moved. The base-ref check is dropped so a retarget before the
run still gets reviewed. The operations doc now describes the monthly wiki
schedule, manual runs and GitHub's 60-day inactivity pause.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
Review CI Steward fix pushes on labelled PRs; note the mentions switch
cda9d05 
The droid-reviewed label skipped Steward fix commits, breaking the CI
Steward promise that every fix push is reviewed. A push from
factory-droid[bot] now bypasses the label. Document that @droid review
needs JHD_FACTORY_MENTIONS_ENABLED.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
Say that removing the label makes the next push eligible
2227342 
Removing droid-reviewed sends an unlabeled event, which the workflow
does not listen to, so the removal alone starts no review.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
Treat a label created by a concurrent review as success
d8aa5a1 
Two first reviews finishing together can both see the label missing;
the second createLabel returns 422 and used to stop the step before
addLabels, leaving a reviewed PR unmarked.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
Confirm the label exists after a rejected create
fb09d8c 
A 422 can also mean an invalid request, so look the label up again and
let that lookup fail if the label is still missing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
Run the wiki refresh only from the default branch, not a same-named tag
79b33a0 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
Cut the review-once change back to what was asked for
5f48052 
Restore main's review workflow and add only the droid-reviewed skip
(with the CI Steward exception) and one addLabels call, which creates
the label when missing. Drop the label bookkeeping, head-move guard,
trigger rewrite and tag check that came from bot review rounds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@claude
Merge remote-tracking branch 'origin/main' into claude/clever-meitner…
e83aed6 
…-iyop54
@claude
Create the droid-reviewed label before adding it
0c0be80 
GitHub's add-labels docs do not promise that a missing label is created,
so create it first and treat 422 (already exists) as success.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@kingdomseed
kingdomseed merged commit 4541ed7 into main Oct 23, 2026
2 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T10:57:26.204518Z 0c0be80 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5a3faadc-dfb2-4c64-9e21-475d79601574
📥 Commits

Reviewing files that changed from the base of the PR and between 2dd019a and 0c0be80.

📒 Files selected for processing: 1
  • .github/workflows/factory-review.yml
+------------------------+
| Code review is my jam. |
+------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

This was referenced Oct 23, 2026
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kingdomseed @claude