Skip to content

ci: create the droid-reviewed label before adding it - #54

Merged
kingdomseed merged 8 commits into
mainfrom
claude/clever-meitner-iyop54
Oct 23, 2026
Merged

kingdomseed merged 8 commits into
mainfrom
claude/clever-meitner-iyop54

Conversation

@kingdomseed

@kingdomseed kingdomseed commented Oct 23, 2026 •

Copy link
Copy Markdown
Collaborator

Copies factory-review.yml from factory-droid-workflows main (#5). GitHub's add-labels docs do not promise that a missing label is created, so the workflow creates droid-reviewed first and treats 422 (already exists) as success.


Generated by Claude Code


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

The legacy Droid Tag and Droid Auto Review workflows ran
Factory-AI/droid-action@main, unpinned, on every PR or @droid mention.
The opt-in factory-review and factory-mentions workflows replace them;
keeping both would give two reviews per PR and two replies per mention
once the replacements are enabled.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
Factory Review now runs when a PR opens ready for review or a draft is
marked ready, not on every push, and labels the PR droid-reviewed. Comment
`@droid review` to ask for another review. Droid Wiki Refresh runs at
06:17 UTC on the 1st of each month instead of on every push to main.
Both files match factory-droid-workflows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
Adding a label that does not exist yet can fail, so the review job now
creates droid-reviewed when the repository lacks it. A manual wiki run
started from another branch would document unmerged code, so generation
runs only on the default branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
…head

Without the synchronize trigger, a push during the first review left the
new commits labelled as reviewed but unseen. Pushes now cancel and restart
the review until the droid-reviewed label exists, and the label step skips
when the head moved. The base-ref check is dropped so a retarget before the
run still gets reviewed. The operations doc now describes the monthly wiki
schedule, manual runs and GitHub's 60-day inactivity pause.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
Copy factory-droid-workflows main: main's review workflow plus a
droid-reviewed skip (CI Steward pushes excepted) and one addLabels call;
the wiki runs monthly or by hand.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
Copy factory-droid-workflows main.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017U3iFTj2nxsbhbdBRHKFzi
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-10-23T10:57:13.508706Z cd9b9d2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 23, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 79562d78-bdbe-41ce-9fad-d5b723ddee46
📥 Commits

Reviewing files that changed from the base of the PR and between e575eb8 and cd9b9d2.

📒 Files selected for processing: 1
  • .github/workflows/factory-review.yml
+---------------------------------------------+
| Because, no one wants to be a human linter. |
+---------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@kingdomseed
kingdomseed merged commit 6b0088a into main Oct 23, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants