Skip to content

ci: run Code Review on Sonnet 5.5 through the Anthropic API key - #8

Merged
kingdomseed merged 1 commit into
mainfrom
ci/review-sonnet-anthropic-key
Oct 27, 2026
Merged

kingdomseed merged 1 commit into
mainfrom
ci/review-sonnet-anthropic-key

Conversation

@kingdomseed

@kingdomseed kingdomseed commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Why the change

Code Review ran on Factory's default model and billed Factory credits; this moves the master review workflow to Claude Sonnet 5.5 on the organization's ANTHROPIC_API_KEY, matching what was proven on mythic-dice-parser.

Special things to note

  • The custom model is written to ~/.factory/settings.json in its own step. The action's settings input writes ~/.factory/droid/settings.json, which Droid ignores for custom models, so reviews silently fell back to the org default (mythic-dice-parser run 40582959530).
  • Verified on mythic-dice-parser PRs #22 and #24: run logs show custom:anthropic-api:sonnet-5-5 and an empty MODEL_FALLBACK_NOTE, and the review caught a planted bug.
  • Review stays off until JHD_FACTORY_REVIEW_ENABLED is true.

Change outline

 review job
+  Register the Anthropic API custom model   (writes ~/.factory/settings.json)
   Run native deep review and security (droid-action v10, unchanged pin)
+    env: ANTHROPIC_API_KEY from secrets
+    review_model / security_model: custom:anthropic-api:sonnet-5-5

Docs: CREDENTIALS.md lists the new secret, PROVENANCE.md records the correction, and OPERATIONS.md names the review model.

Merge risk

Merge risk: low

Alignment: good ✅

  • Jason asked for the same Anthropic-key review across JHD repositories.

Impact: small ✅

  • One workflow step plus docs; repositories get it through separate PRs.

Verification: good ✅

  • Validator, Python and Node tests pass; two live review runs on mythic-dice-parser.

Rollback cost: low ✅

  • Revert to return to the Factory default model.

Error detection: decent 👀

  • A failed model load shows MODEL_FALLBACK_NOTE in the PR tracking comment.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T21:56:44.539407Z d1bac6d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@kingdomseed
kingdomseed merged commit 8a069e7 into main Oct 27, 2026
6 of 7 checks passed
@kingdomseed
kingdomseed deleted the ci/review-sonnet-anthropic-key branch October 27, 2026 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant