Skip to content

Fix iteration to terminate #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javizqh merged 1 commit into from
Sep 2, 2026
Merged

Fix iteration to terminate #301

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion robotics_application_manager/manager/launcher/launcher_o3de_api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ def run(self, callback):
def terminate(self):
self.gz_vnc.terminate()
if self.threads is not None:
for thread in self.threads:
for thread in self.threads[:]:
if thread.is_alive():
thread.terminate()
thread.join()
Expand Down
2 changes: 1 addition & 1 deletion robotics_application_manager/manager/vnc/vnc_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ def is_running(self):

def terminate(self):
"""Terminate all running threads and stop the VNC server."""
for thread in self.threads:
for thread in self.threads[:]:
if thread.is_alive():
thread.terminate()
thread.join()
Expand Down
Loading