Repository navigation
Fixed possible going out of bounds behavior in list iterator decrements, detected in Debug build by VS 2026, that caused related assert to be triggered - #206
Open
mamontov-cpp wants to merge 1 commit into
Conversation
…ts, detected in Debug build by VS 2026, that caused related assert to be triggered
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main idea of this PR is to fix asserts obtained in debug builds on MSVS 2026. These asserts were triggered because, when deleting elements from linked std::lists, the code decremented an iterator that could already be at begin(). Accordingly, the decrement led to going out of bounds. The fix addresses this behavior by simply staying at the position of the new iterator when a deletion occurs, and moving forward if there was no deletion. The fix includes three places where this was found and reproduced in the game.