Skip to content

dummydevice and musiccast READMEs show the old plugin API #218

Description

@kalinka-player-bot

packages/kalinka-plugin-dummydevice/README.md:62-65 and packages/kalinka-plugin-musiccast/README.md:62-65 still show from kalinka_plugin_sdk.api import PluginContext and a module-level def setup(cfg, ctx) -> ExternalOutputDevice. Neither exists any more: plugins subclass OutputDevicePlugin from kalinka_plugin_sdk.plugin and implement async def setup(self, context: OutputDevicePluginContext). Both READMEs were generated from an early version of the template, which this branch has since corrected.


Filed by Kalinka Bot while working on Plugin template pins the SDK to >=2.0,<3 while the SDK is 3.4.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bot-foundFound by Kalinka Bot while working on something elsedocumentationImprovements or additions to documentationpriority: P3Minor or nice to have

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions