cleaned up RegisterSpawnPlacementEvent patch - #19
Closed
ItsBlackGear wants to merge 3 commits into
Closed
ItsBlackGear wants to merge 3 commits into
ItsBlackGear wants to merge 3 commits into
Conversation
BluSpring
requested changes
Jul 27, 2026
| if (operation != Operation.REPLACE && (heightmap != null || placementType != null)) { | ||
| throw new IllegalStateException("Nonnull heightmap types or spawn placement types may only be used with the REPLACE operation. Entity Type: " + BuiltInRegistries.ENTITY_TYPE.getKey(entityType)); | ||
| } | ||
| // Kilt: patch by @ItsBlackGear to fix Vanilla Backport (Fabric) + NML + Kilt, may be upstreamed. |
Member
There was a problem hiding this comment.
I think you can remove the comment here tbh
Member
There was a problem hiding this comment.
or comment out the original operation
BluSpring
requested changes
Jul 27, 2026
BluSpring
requested changes
Jul 27, 2026
Author
|
i'll PR from another branch as i couldn't rollback to make it keep the upstream authors lol |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a revisited and cleaner version of the patch, matching neoforged#3358