Name the COCO frame rate annotation_fps - #1865
Merged
Merged
Conversation
The rate on the video entry is the downsampled rate detections were produced at, not the video's native one, so VIAME writes it as annotation_fps. Renames the key on both the import and export sides.
The export test still expected the old key.
BryonLewis
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1861. The rate written on the COCO video entry is the rate detections were produced at — the downsampled
-frate, not the video's native rate — so VIAME now writes it asannotation_fps(VIAME/VIAME@9b1227cc6). This renames the key on DIVE's side to match.Without this, #1861's importer reads
videos[].fpswhile current VIAME writesvideos[].annotation_fps, so the frame rate does not survive a VIAME to DIVE import.frame_rate_from_coco()reads it,export_dive_as_coco()writes itframeRateFromDocument()reads it,serializeFilewrites itdocs/DataFormats.md, including the section anchor and the two links to itfps; only the COCO wire spelling changesVerified against real
process_video.pyoutput: desktopparseFilegivesmeta.fps = 5for a video andundefinedfor an image list; server import gives5.0, export then writes[{'id': 1, 'name': 'clip', 'annotation_fps': 5.0}], and re-import gives5.0back.Not run: vitest, eslint and tsc — no
node_modulesin this checkout. Server-side checks were executed directly.