Summary
bugprone-throwing-static-initialization is already disabled repo-wide in .clang-tidy:13:
-bugprone-throwing-static-initialization,
Four NOLINT suppressions for that same check are still scattered through the test sources. They suppress nothing — the check never runs — so they are pure noise, and they read as if the code had a real finding being silenced.
They also sit awkwardly against AGENT.md, which says clang-tidy reports must be fixed at the source and never silenced with NOLINT.
Occurrences
src/tests/Utils.hpp:166 — //NOLINT(bugprone-throwing-static-initialization) on DefaultTestConnectionStringsrc/tests/Utils.hpp:400 — // NOLINT(bugprone-throwing-static-initialization) on testDatabaseNamesrc/tests/MigrationTests.cpp:52 — // NOLINT(bugprone-throwing-static-initialization) on a LIGHTWEIGHT_SQL_MIGRATIONsrc/tests/DataBinderTests.cpp:23 and :3821 — the check listed inside a NOLINTBEGIN/NOLINTEND pair (alongside readability-container-size-empty and bugprone-unchecked-optional-access, which are not globally disabled and must stay)
Proposed change
Drop the check from all four sites, keeping the other checks named in the DataBinderTests.cpp block. Then confirm clang-debug is still clean, since that preset runs clang-tidy automatically.
If the intent was instead to re-enable the check repo-wide, that is the opposite change and would need the four sites looked at on their merits — worth deciding explicitly either way.
Summary
bugprone-throwing-static-initializationis already disabled repo-wide in.clang-tidy:13:Four
NOLINTsuppressions for that same check are still scattered through the test sources. They suppress nothing — the check never runs — so they are pure noise, and they read as if the code had a real finding being silenced.They also sit awkwardly against
AGENT.md, which says clang-tidy reports must be fixed at the source and never silenced withNOLINT.Occurrences
src/tests/Utils.hpp:166—//NOLINT(bugprone-throwing-static-initialization)onDefaultTestConnectionStringsrc/tests/Utils.hpp:400—// NOLINT(bugprone-throwing-static-initialization)ontestDatabaseNamesrc/tests/MigrationTests.cpp:52—// NOLINT(bugprone-throwing-static-initialization)on aLIGHTWEIGHT_SQL_MIGRATIONsrc/tests/DataBinderTests.cpp:23and:3821— the check listed inside aNOLINTBEGIN/NOLINTENDpair (alongsidereadability-container-size-emptyandbugprone-unchecked-optional-access, which are not globally disabled and must stay)Proposed change
Drop the check from all four sites, keeping the other checks named in the
DataBinderTests.cppblock. Then confirmclang-debugis still clean, since that preset runs clang-tidy automatically.If the intent was instead to re-enable the check repo-wide, that is the opposite change and would need the four sites looked at on their merits — worth deciding explicitly either way.