Repository navigation
docs: add review-and-recall Blueprints and documentation ownership - #151
Conversation
timeleft--
left a comment
There was a problem hiding this comment.
Independent Captain source review of this exact head is consolidated in the formal REQUEST_CHANGES review on companion site PR MachineWisdomAI/fava-trails.org#39, the canonical PR for the existing child #32 root. The lifecycle failure table must distinguish outer timeout (draft unchanged) from provider timeout returned as an error verdict (record becomes error; author cannot re-propose). The local-default Blueprint already has that distinction. Repair through the existing child task on these same PRs; do not create another root or repair relay. The proposed compatibility-preserving bootstrap contract otherwise fits the delegated scope. Final design acceptance will be recorded after corrected-head review, without a human-attention gate.
timeleft--
left a comment
There was a problem hiding this comment.
Independent Captain review of exact head dc7085a. The lifecycle table now correctly distinguishes outer timeout from a recorded provider error, resolving the companion review finding. Reused the unchanged source/Blueprint assessment from d1b2d0e and inspected the complete changed table against tools/navigation.py, trust_gate.py and trail.py. The compatibility-preserving local bootstrap design, ownership boundaries, governed lifecycle and scoped failure claims fit issue #32. Local version-policy check and whitespace validation pass; hosted runtime tests are still pending and are not claimed passed here. This is documentation/design approval, not evidence of a new default, real-model quality or package publication. Under the user's delegated coordinator authority I accept the three feature/module designs at this reviewed revision; their status/evidence fields must be updated in the already-planned implementation and contributor changes, without a new human approval gate. Merge this companion before site PR #39 once all actual required checks pass.
What this adds
Design records and an ownership map for the review-and-recall lifecycle, so an engineer can follow draft → review → approved recall → correction and a contributor can find the authoritative explanation for each behavior.
blueprints/with a short guide: the lifecycle feature, the review-gate module, a proposed local-review-default feature, and a codebase map ofsrc/fava_trails.docs/documentation-ownership.md: one owner per fact, approved and avoided wording (replaces "crash-proof" and "no contradictory memories" with accurate statements), and the separation of approved design, implementation and release evidence.docs/governed-recall.md: states which writes use the before-image journal and what an interruptedsave_thought/update_thoughtcan leave behind.CONTRIBUTING.md: one line pointing contributors at the ownership map and Blueprints.No runtime code changes. Docs only, so the version policy requires no bump (
scripts/mw-version.py check --base origin/mainpasses: repo stays 0.8.5-rc.1).Evidence
0f7c01f. Existing fixture tests for configuration, the review gate, governed visibility, local-only sync and navigation: 236 passed (jj 0.45.1). These use fixture servers; no real model was run, and the documents say so.GlobalConfigfor each case, not inferred.llm-oneshotforms, a bootstrap path that could send text to hosted OpenAI, unspecified handling of the shared per-machine config, "sync never publishes" being false underpush_strategy: immediate, and two lifecycle recovery claims). Round two confirmed those resolved and found further gaps in the new bootstrap and check design; those revisions are in the head. The final revision after round two was not re-reviewed.Needs the coordinator
Blueprint design status is
draft. Approval is the delivery coordinator's to record under the delegated authority; this PR does not claim it. A status-only commit should pin the reviewed revision after merge.Not changed here (reconciliation list for the later tickets)
syncnever publishes:AGENTS_SETUP_INSTRUCTIONS.md:285,AGENTS_USAGE_INSTRUCTIONS.md:111, thesyncandpropose_truthtool descriptions inserver.py, and the data-repo template guides.llm-oneshotignorestrust_gate_timeout_secsper request (60 s per attempt), yet the setup guide recommends 240 s for slow local models.AGENTS.md/CLAUDE.mdstale claims are handled in the companion fava-trails.org PR; page components carrying the same wording are website-journey work.