fix(account-tree-controller): reset mappings and selected account in clearState - #9825
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 659e648. Configure here.
gantunesr
approved these changes
Aug 13, 2026
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. Learn how to use preview builds in other projects. Expand for full list of packages and versions. |
salimtb
approved these changes
Aug 13, 2026
salimtb
left a comment
salimtb
left a comment
Contributor
There was a problem hiding this comment.
tested using a local build, LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
We were not completely resetting the transient state of the
AccountTreeControllerduringclearState.We now properly clear the mappings and fire an
''(empty) selected account group, since the tree will be empty.References
Checklist
Note
Medium Risk
Touches wallet-reset and account-selection event flow across controllers; behavior change is intentional but consumers must already handle empty
selectedAccountGroupChangeas documented.Overview
AccountTreeController.clearStatenow fully tears down transient state on wallet reset: it clears in-memory reverse-lookup maps (#accountIdToContext,#groupIdToWalletId) and publishesAccountTreeController:selectedAccountGroupChangewith an empty new group id (''), matching normal selection transitions.AssetsControllerlistens for that event’sgroupIdand skipsgetAssetswhen the id is empty (onboarding or reset), avoiding pointless fetches against a cleared tree. Tests cover map clearing, the empty-group event payload, and the assets no-op path.Reviewed by Cursor Bugbot for commit 9b0921f. Bugbot is set up for automated code reviews on this repo. Configure here.