Repository navigation
[REFACTOR] CacheErrorHandler를 커스텀 및 outbox 패턴 수정 사항 - #71
Merged
Hidden character warning
The head ref may contain hidden characters: "chore/66-chore-ci-cd-\ubc0f-prometheus-grafana"
Merged
Conversation
…s-grafana' into chore/66-chore-ci-cd-및-prometheus-grafana
This comment was marked as resolved.
This comment was marked as resolved.
github-actions
Bot
requested review from
Jinyoung-Kim96,
Sehi55,
ji-circle,
jihxonx and
qldo
May 17, 2026 14:37
…tionQueryServiceImpl
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci-prod.yml:
- Line 34: The Gradle JVM property flag (-Dspring.profiles.active=test) won't be
propagated to test worker JVMs; ensure the test profile is enforced by either
setting the SPRING_PROFILES_ACTIVE environment variable for the test step or by
adding a test systemProperty passthrough in Gradle. Update the CI job to export
SPRING_PROFILES_ACTIVE=test (or set it in the step environment) or modify
build.gradle to include test { systemProperty 'spring.profiles.active',
System.getProperty('spring.profiles.active') } so tests reliably receive the
test profile.
In
`@src/main/java/com/michelet/reservation/infrastructure/outbox/OutboxEventScheduler.java`:
- Around line 37-45: The transaction block in OutboxEventScheduler (the
transactionTemplate.execute lambda that calls
outboxEventJpaRepository.findPendingForProcessing and
OutboxEventJpaEntity::markProcessing) can leave events stuck in PROCESSING if
InterruptedException causes an early return; change the lambda to not swallow
InterruptedException — catch it, call Thread.currentThread().interrupt(), and
rethrow as a RuntimeException (or propagate) so the transaction is rolled back
and markProcessing/saveAll are not committed; apply the same change to the
second transaction block around lines 57-60 to ensure interrupted threads do not
persist PROCESSING state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: e909c6bc-bc0f-4fea-abf7-65f8c0642c31
📒 Files selected for processing (8)
.github/workflows/ci-prod.ymlsrc/main/java/com/michelet/reservation/application/reservation/ReservationQueryServiceImpl.javasrc/main/java/com/michelet/reservation/config/RedisCacheConfig.javasrc/main/java/com/michelet/reservation/infrastructure/outbox/OutboxEventScheduler.javasrc/main/java/com/michelet/reservation/infrastructure/outbox/OutboxStatus.javasrc/main/java/com/michelet/reservation/infrastructure/outbox/entity/OutboxEventJpaEntity.javasrc/test/java/com/michelet/reservation/ReservationServiceApplicationTests.javasrc/test/resources/application-test.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업 내용
🚀 주요 변경 사항
✅ 자체 체크리스트 (필수)
./gradlew build실행 결과 정상 (인증샷 첨부)📸 테스트 인증샷
💬 리뷰어 전달사항 (선택)
📎 참고 자료
Summary by CodeRabbit
릴리스 노트
버그 수정
기능 개선
테스트