removing ambiguous keyword bool arg calls - #337
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #337 +/- ##
=======================================
Coverage 94.86% 94.87%
=======================================
Files 58 58
Lines 2746 2751 +5
=======================================
+ Hits 2605 2610 +5
Misses 141 141 🚀 New features to boost your workflow:
|
ali-ramadhan
approved these changes
Nov 17, 2025
ali-ramadhan
left a comment
ali-ramadhan
left a comment
Member
There was a problem hiding this comment.
Didn't know about FBT001 and FBT002 but I'm a big fan.
Since this is a breaking change are we accumulating changes to release v3.0 with no more v2.x releases?
ali-ramadhan
requested changes
Nov 17, 2025
ali-ramadhan
left a comment
ali-ramadhan
left a comment
Member
There was a problem hiding this comment.
Might have found a bug and an opportunity to add a test so I'm requesting changes instead of approving. But let me know if I'm wrong!
Forcing the init_db argument to be keyword only minimizes confusion and improves readability.
jtpavlock
force-pushed
the
lint_checks
branch
from
November 18, 2025 06:38
bd96657 to
adebbe1
Compare
Replaces the `overwrite` bool argument in library item `merge` methods with a new `MergeStrategy` enum. This increases readability and allows for future implementation merge strategies without introducing new breaking changes.
Forcing the argument to be keyword only increases readability.
Forcing keyword only increases readability.
jtpavlock
force-pushed
the
lint_checks
branch
from
November 18, 2025 15:31
adebbe1 to
b506040
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This removes the ability to call any boolean arguments in function just by passing
Trueor "False" and forces them to be passed by keyword such asoverwrite=False.The following functions changed:
overwriteis now a keyword forced argcreate_fieldis now keyword onlyinit_dbin__init__is now keyword onlySee each commit for more details on each specific change. These are all breaking changes.
Additional information
See ruff FBT001 and FBT002 for more info.
📚 Documentation preview 📚: https://mrmoe--337.org.readthedocs.build/en/337/