Repository navigation
Add check-dependency-graph reusable workflow - #1131
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DbF799uMdieeoBVQFaapJg
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…reference Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DbF799uMdieeoBVQFaapJg
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DbF799uMdieeoBVQFaapJg
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Kept both sides of every conflict: check-paired-file-change and check-write-idiom from main beside check-dependency-graph. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DbF799uMdieeoBVQFaapJg
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DbF799uMdieeoBVQFaapJg
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DbF799uMdieeoBVQFaapJg
|
Claude finished review — View run This review covers the three unreviewed commits since the last round, up to The prior round (comment from 2026-10-19, commit What changed since then
VerdictReady for merge. The earlier blocking finding is fixed, and the merge commits and the wrap commit introduce nothing new. The optional Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "26d6974cd57a282e690cbed7fd155e1e3f76f45f",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Commit 26d6974 only rewraps versioning list entries, and the two merge commits keep both sides of every conflict, with the readonly-workflows lists in README.md and website/permissions.qmd still naming check-dependency-graph.",
"holistic_assessment": "The net diff against main is limited to the check-dependency-graph additions, nothing from main was dropped, and the prior Ready for merge verdict remains valid with the selftest job as an optional follow-up."
}Reviewed commit: 26d6974 |
2026-10-19 11:06 UTC |
|
Merge note: merged as bf1f93d at head 26d6974 under Ezra's typed "mwc all". The cross-harness adversarial review and Generated by Claude Code |
Important
Stacked on gha#1126, which adds the script this workflow runs. Merge #1126 first, with a merge commit, not a squash.
Before: notes repos that vendor
build_dependency_graph.pyhave its self-test intools/tests/, but nothing runs it, so reviews of win#130 and rme#1390 flag it as unwired.After: a repo adds a one-job caller of
check-dependency-graph.yml. It runs the vendored self-test, then builds the graph and fails on a cycle. Closes #1129.What it does: two
python3steps in the caller's checkout, readingscript-dir,pages-dir,siteandfail-on-cycle. It uses no composite, so it has no@v3bootstrap gap of its own. Callers pin@v3, which resolves once the tag slides past this merge.How: I added the workflow, its example stub, reference page and sidebar entry, README and website table rows, the six versioning lists that
audit_capability_versioning_docs.pychecks, and a changelog fragment.Checked locally: that audit reports no findings, and the self-test and
--failbuild pass on lds (353 nodes, 0 cycles). I did not run the workflow itself, because a reusable workflow cannot be called from this repo until the tag slides.Generated by Claude Code