Skip to content

Add the floor function and the logarithm to base b - #566

Merged
d-morrison merged 10 commits into
mainfrom
claude/project-thread-aj2ep4-floor-log
Nov 3, 2026
Merged

d-morrison merged 10 commits into
mainfrom
claude/project-thread-aj2ep4-floor-log

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

This is part of the mds/mcs consolidation that Ezra approved on 2026-11-02. It was split from Morrison-Lab/mds#565 to keep each PR under the size cap. The two PRs touch different parts of _number-systems.qmd and references.bib, so they can merge in either order.

What changes

  • Number systems page, after the real numbers:
    • def-floor, the floor of a real number.
    • exm-floor, with a staircase figure.
  • Algebra page, after the real power:
  • references.bib: adds wikipedia_floor_ceiling.

The ids are the same as in the mcs CSCI 201 notes, so mcs can include these files without changing its links.

Checks

  • check-term-links, check-new-line-breaks (on *.md and *.qmd) and check-exm-figures pass locally against origin/main.
  • Both pages now have R figure chunks. This session has no rmarkdown, so CI is the first render of the figures.

Generated by Claude Code

Both were local to the mcs course notes (CSCI 201) and are general math,
so they move here under the mds/mcs consolidation approved on 2026-11-02.
The ids (def-floor, def-logarithm) match mcs. The logarithm allows any
base b > 0 with b != 1, and a remark derives log_b x = ln x / ln b,
which also shows the value is unique. Each definition has an example
with a figure. Split from #565 to keep each PR small.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

The remark cites thm-exp-log-inverse, which came later in the section,
so it was a forward reference. It now follows the theorem, cites each
part for each direction of the equivalence, and states the formula.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox

Copy link
Copy Markdown
Contributor Author

Addressed the review in the latest push:

  • Forward reference (blocking): rem-logarithm-formula now comes right after thm-exp-log-inverse, so it no longer cites a theorem the reader hasn't reached.
  • Which part of the theorem: the remark now proves the equivalence both ways. Part 1 covers "if $y \log b = \log x$, then $\exp(y \log b) = x$". Part 2 ("apply $\log$ to both sides") covers the converse.
  • Final formula: the remark now states $\log_b x = \log x / \log b$ as a display equation.
  • Line break: "Since $b \ne 1$," is now on its own line.
  • \log_b macro: the shared macro library has no base-$b$ logarithm macro, so \log_b stays raw for now. If one is wanted, it belongs in Morrison-Lab/macros, not here.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

lint-changed-lines flags data.frame() as an undesirable function.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox

Copy link
Copy Markdown
Contributor Author

@claude review

The automatic review on 283fedd was skipped after its run was preempted, so this head has no verdict yet.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

👀 Picked up by workflow run #41499215112. Setup runs first; Claude itself responds after that.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

check-avoided-words, added to main in #567, flags it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

d-morrison and others added 2 commits November 2, 2026 16:48
gha v3 now flags "term (@Def-x)" on added lines (gha#1402). The five
flagged lines in the floor and logarithm subfiles now link the term itself.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I fetched PR #566 live just now. It is open, not a draft and not merged (mergedAt is null). Its head is 1e82617a02a5deb74310d3efa1a8463dfa6dacf3, the commit I reviewed, so the review above still applies.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "1e82617a02a5deb74310d3efa1a8463dfa6dacf3",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The only hand-resolved file, references.bib, keeps both the floor_ceiling entry and main's three new wikipedia entries with no conflict markers, no duplicate keys, and well-formed BibTeX.",
  "holistic_assessment": "The PR's own scope is unchanged since the prior Ready for merge verdict, and the remaining merged content is main's already-reviewed divisibility work, so no integration or regression concerns arise."
}

Reviewed commit: 1e82617

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2142 (review) — run

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-11-03 01:48 UTC

Copy link
Copy Markdown
Contributor Author

Cross-model review waived for head 1e82617: OpenCode Go returned HTTP 429 (GoUsageLimitError, monthly limit) at 00:50 UTC for deepseek-v4-pro, kimi-k3, qwen3.8-max and glm-5.3, and the network proxy refuses ollama. The Claude review of 1e82617 is Ready for merge, every check is green, the head is current with main, and check-pr-fully-clean passes. Ezra granted mwc for this PR in the project thread.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@d-morrison
d-morrison merged commit 88e071a into main Nov 3, 2026
40 checks passed
d-morrison added a commit that referenced this pull request Nov 3, 2026
* Raise the publish timeout to 180 minutes

The Quarto Publish run for 88e071a (#566) was cancelled by the
120-minute cap, not by a render error: html took 32 minutes, revealjs
30, docx 24, and the per-file PDF pass had 14 of 48 pages left at
about 55 seconds each. The previous successful build already took 114
minutes, so the site's growth, not any one page, crossed the cap.

Splitting formats into parallel jobs (Morrison-Lab/gha#1420) would cut
the wall time; this raises the cap until that exists.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9npwsVzzQyzTALcNz9

* Skip the web.stanford.edu phil150 link in the link check

lychee fails it with "SSL certificate not trusted" on every PR since
2026-11-03 (mds#589 and this PR), though neither touches the page that
links it, so the link check is red repo-wide. Same treatment as the
Stanford page excluded on 2026-10-22; remove once the chain verifies.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9npwsVzzQyzTALcNz9

---------

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants