Repository navigation
Promote all mds section headings to level 1 - #587
Conversation
… 0.1, 0.2 number-sections numbers by heading level and the page title is not a numbered level, so a page whose first body heading is level 2 numbers its sections 0.1, 0.2. Heading text is unchanged, so anchors and links are unchanged. Part of #568 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9mgFxbUyGpESuW5TVR
… 0.1, 0.2 number-sections numbers by heading level and the page title is not a numbered level, so a page whose first body heading is level 2 numbers its sections 0.1, 0.2. Heading text is unchanged, so anchors and links are unchanged. Part of #568 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9mgFxbUyGpESuW5TVR
… 0.1, 0.2 number-sections numbers by heading level and the page title is not a numbered level, so a page whose first body heading is level 2 numbers its sections 0.1, 0.2. Heading text is unchanged, so anchors and links are unchanged. Part of #568 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9mgFxbUyGpESuW5TVR
Pages and the fragments they include started their sections at level 2, so number-sections rendered 0.1, 0.2 and so on. This moves every page body and included fragment up one level together, so sections number 1, 2, 3, splits the indicator section into one div per subfile (a pure move) so the one-div-per-subfile check can pass, updates split-page-headings.lua for the new level, and sets the revealjs heading shift to 1 so each section is one slide. Replaces the partial PRs, whose reviews saw a half-converted tree. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9r2idFsJ4pHCsRGyGx
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…er 1.1 to 1.3 The subsections sat one level too deep after the page promotion, so they rendered as 1.0.1 to 1.0.3. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9r2idFsJ4pHCsRGyGx
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Annotations read on head 849e3e9 (all 40 check runs; every check green).
Generated by Claude Code |
|
Claude finished review — View run I just fetched PR #587 live. It is open, not a draft, and not merged. Its head is still This is a confirming review. No commit of the PR's own has landed since the last round. I did not re-read the whole diff or render the site. The PR head moved from The prior review, posted 2026-11-02 on commit 849e3e9, was CLEAN. It stands. That review built on the earlier CLEAN review of commit 8e213a3. Two non-blocking observations from the earlier rounds still apply:
VerdictReady for merge. The merge of Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "b3efc28b860b320b74de4ee95e31b23d90420367",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The only change since the last round is a clean merge of main whose remerge-diff matches git's automatic result, so the heading demotions and indicator-function subfiles reviewed earlier are unchanged.",
"holistic_assessment": "No new PR-authored commits, section ids and URL anchors are unchanged, and the earlier CLEAN verdict still applies; the rendered slide output was not built in this review."
}Stopping Point: Not a clean stopping point / work remains queued: session not done; this was an automated review-only run, so no files were changed or committed and nothing is queued. UMS was not executed. Reviewed commit: b3efc28 |
2026-11-03 00:01 UTC |
|
Merged on Ezra's typed mwc (2026-11-02 14:55 PST) at head b3efc28, after the clean Claude review of that head, all 40 checks green, and the annotation read above. The cross-harness review is waived: the agy and OpenCode Go quotas are exhausted, and the lab bars Codex and pay-per-use APIs. The waiver follows adversarial-self-review.md. Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
One mechanical PR, at Ezra's choice (decision card, 2026-11-02 13:46 PST), replacing the partial PRs #569, #570, #571, #582, #583, #584, #585 and #586. Their reviews each saw a half-converted tree, so none could come back clean. It exceeds the PR size cap on purpose (
ALLOW_LARGE_PR).Why: every page and fragment started its sections at level 2, so
number-sections: truenumbered them 0.1, 0.2 and so on. The check that required this (ghacheck-heading-levels) now requires a level 1 start (Morrison-Lab/gha#1399).What changes:
_quarto-website.ymlsetsshift-heading-level-by: 1for revealjs, so each section is still one slide underslide-level: 2.split-page-headings.luanow drops a level 1 title heading and shifts deeper headings up one.check-one-div-per-subfilepasses), then its headings are promoted.rem-iverson-indicatoris also moved to its own subfile.Checked: an include-expanding script finds no page that starts deeper than level 1 or skips a level; a local render numbers sections 1 to 6 with one
h2per section in the slides.Generated by Claude Code