Skip to content

Group the calculus-free foundation topics first - #588

Merged
d-morrison merged 7 commits into
mainfrom
claude/project-thread-aj2ep4-foundations
Nov 3, 2026
Merged

d-morrison merged 7 commits into
mainfrom
claude/project-thread-aj2ep4-foundations

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

The home page and navigation interleaved the topics that need no calculus with the ones that do, so a reader could not tell which pages a discrete-math course (such as Math for Computer Science) can build on.

Changes

  • _quarto-website.yml: Proof Writing and Induction and Recursion move to right after Algebra, in both the navbar and the sidebar (the sidebar sets the previous/next order), so the six calculus-free topics come first.
  • index.qmd: the topic list is split into "the foundations" (Notation, Number Systems, Sets and Functions, Algebra, Proof Writing, Induction and Recursion) and "the remaining topics", which build on the foundations. A new Induction and Recursion bullet links its two defined terms.

Algebra mentions limits and integral notation in a few remarks, so the paragraph says so rather than claiming the foundations never touch calculus (caught by the pre-push adversarial review).

No page path or #id anchor changes, so links from other sites still resolve.

Local checks: check-term-links, check-new-line-breaks and check-avoided-words pass on the diff.


Generated by Claude Code

Proof Writing and Induction and Recursion sat at the end of the navbar,
after Optimization, although neither uses calculus.
They now follow Algebra, so the six topics that assume no calculus come
first in the navbar, the sidebar and the previous/next order.
The home page splits its topic list the same way and says that a
discrete-math course such as mcs can build on the foundations directly.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox
The Algebra pages mention limits and integral notation, so the
foundations do not assume no calculus at all.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox
check-term-links flagged "limits" and "integral" as unlinked first uses
of defined terms. Rewording keeps the caveat without linking calculus
terms from the foundations paragraph.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pMBq15Hq3DgNBx1ox
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Confirming review: the earlier Ready for merge verdict (comment of 2026-11-02, commit 74deedc) still stands. I found no new issues.

The diff against main still touches only _quarto-website.yml and index.qmd. The range since 74deedc holds no commits of this PR's own. The merge commit eb555f5 matches git's automatic merge of its parents, so it adds nothing new to review.

What I checked this round

  • Navbar and sidebar order: "Proof Writing" and "Induction and Recursion" sit right after Algebra in the navbar and in the sidebar, in the same order. The previous/next arrows follow the sidebar, so they follow the same sequence.
  • Count in the new text: "The first six topics" matches the list of Notation, Number Systems, Sets and Functions, Algebra, Proof Writing, and Induction and Recursion.
  • Paths and anchors: proof-writing.qmd and induction.qmd keep their paths. The #def-recursive-sequence and #def-strong-induction anchors were confirmed in the first round, and nothing has changed them.
  • Math macros: the diff adds no math, so the macro check does not apply.
  • Line breaks: each added prose line holds one sentence or one clause.

Not checked: I did not verify the editorial claim that Algebra has only a few remarks touching on calculus. As in the earlier rounds, it doesn't block merge.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "eb555f58ae10b3b1c7b55ab3496b50eaf8377396",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Navbar and sidebar entries for proof-writing and induction remain moved consistently after Algebra in _quarto-website.yml, and the index.qmd list count of six foundation topics matches the text.",
  "holistic_assessment": "Change stays scoped to navigation order and index intro text, keeps page paths and anchors stable, adds no math or code, and the latest merge from main matches git's automatic merge."
}

Reviewed commit: eb555f5

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2013 (review) — run

@github-actions

github-actions Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-11-03 00:48 UTC

Copy link
Copy Markdown
Contributor Author

Cross-model review waived for head eb555f5: OpenCode Go returned HTTP 429 (GoUsageLimitError, monthly limit) for deepseek-v4-pro, kimi-k3, qwen3.8-max and glm-5.3 just now, and the network proxy refuses ollama, so no reviewer outside Claude can run in this session. The Claude review of eb555f5 is Ready for merge, every check is green, and check-pr-fully-clean passes.

The head is 9 commits behind main. Those commits touch none of this PR's files (_quarto-website.yml, index.qmd) and no workflow, and main has moved on during each of the last two ~45-minute rebuilds, so I am merging without a third update. Ezra granted mwc for this PR in the project thread.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@d-morrison
d-morrison merged commit 9ae6479 into main Nov 3, 2026
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants