Repository navigation
Give the gradient explorer 3D figure a fig- id - #624
Merged
Merged
Conversation
Closes #607 (all seven vector-calc contour figures; the interactive gradient explorer is out of scope there). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…lotted surface Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…to claude/project-thread-qgkfho
The contour-line example had no surface plot. The new figure draws the bowl with the circles at heights 1, 4 and 9 and the two example points. The tilt-a-plane figure already shows its plane in 3D, so it is marked no-3d. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Its file holds two top-level divs, so editing it trips the one-div-per-subfile check; the contour-3d check only reads added lines, so it needs no exemption. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The lint-changed-lines check flags nested calls. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The graph of the chosen function with the same point, level curve and arrows, drawn in a separate subfile that reads the explorer's cells. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
It holds only OJS code, which lintr parses as R, as for the other OJS figures. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…ass on the figure A figure div that is itself content-visible crashed Quarto's filter in the revealjs render. The explorer nests them the same way. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…gures have Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
… float id Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
This reverts commit 53d8c84.
Contributor
|
Claude finished review — View run I found no blocking issues in this PR. It changes one line, in
VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "c82f07e6a61d0b1cf9f80a30e65cd0baa5720294",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The single changed line renames the div id in _fig-gradient-explorer-3d.qmd to fig-gradient-explorer-3d, matching the sibling figure; no in-repo references to the old id exist and the div already has a caption paragraph.",
"holistic_assessment": "The change is minimal and in scope; the only residual risk is external course sites linking to the old anchor, which could not be checked from this repository."
}Reviewed commit: c82f07e |
Contributor
Contributor
2026-11-04 17:41 UTC |
Contributor
Author
|
Merged on Ezra's "mwc". Cross-harness review waived: the one non-Claude route in this session (opencode.ai) was blocked by the auto-mode classifier, and no other CLI reviewer is installed. The checker exited 0 on head c82f07e, CI was green with the freeze cache bypassed, and the Claude review was clean. Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #623 (merged). The 3D figure kept a plain div id (
gradient-explorer-3d) from the CI bisect, so it had no float number. This restoresfig-gradient-explorer-3d, as the sibling figures have.The earlier CI crash came from the restored freeze cache, not from this id: head a2115f8 built green with the "clear freezer" label, and a control build without the include was also green. Checked locally:
vector-calculus.qmdrenders to html, revealjs and docx with no errors, and the rendered page contains thefig-gradient-explorer-3did. I haven't looked at the figure in a browser.The branch history carries a
-s oursmerge of the already-merged #623 commits so the push is a fast-forward; the net diff against main is the one-line id change.I added the "clear freezer" label so the preview ignores the freeze cache.
Generated by Claude Code