Skip to content

Give the gradient explorer 3D figure a fig- id - #624

Merged
dem-extra1 merged 28 commits into
mainfrom
claude/project-thread-qgkfho
Nov 4, 2026
Merged

dem-extra1 merged 28 commits into
mainfrom
claude/project-thread-qgkfho

Conversation

@dem-extra1

Copy link
Copy Markdown
Contributor

Follow-up to #623 (merged). The 3D figure kept a plain div id (gradient-explorer-3d) from the CI bisect, so it had no float number. This restores fig-gradient-explorer-3d, as the sibling figures have.

The earlier CI crash came from the restored freeze cache, not from this id: head a2115f8 built green with the "clear freezer" label, and a control build without the include was also green. Checked locally: vector-calculus.qmd renders to html, revealjs and docx with no errors, and the rendered page contains the fig-gradient-explorer-3d id. I haven't looked at the figure in a browser.

The branch history carries a -s ours merge of the already-merged #623 commits so the push is a fast-forward; the net diff against main is the one-line id change.

I added the "clear freezer" label so the preview ignores the freeze cache.


Generated by Claude Code

claude added 28 commits November 3, 2026 21:44
Closes #607 (all seven vector-calc contour figures; the interactive
gradient explorer is out of scope there).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…lotted surface

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The contour-line example had no surface plot. The new figure draws the
bowl with the circles at heights 1, 4 and 9 and the two example points.
The tilt-a-plane figure already shows its plane in 3D, so it is marked
no-3d.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Its file holds two top-level divs, so editing it trips the one-div-per-subfile check; the contour-3d check only reads added lines, so it needs no exemption.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The lint-changed-lines check flags nested calls.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
The graph of the chosen function with the same point, level curve and arrows, drawn in a separate subfile that reads the explorer's cells.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
It holds only OJS code, which lintr parses as R, as for the other OJS figures.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…ass on the figure

A figure div that is itself content-visible crashed Quarto's filter in the
revealjs render. The explorer nests them the same way.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
…gures have

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
… float id

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFvLRB6rfTz2CzRQQz
@dem-extra1 dem-extra1 added the clear freezer Re-render every page in the PR preview, ignoring the freeze cache label Nov 4, 2026 — with Claude
@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I found no blocking issues in this PR. It changes one line, in _subfiles/vector-calc/_fig-gradient-explorer-3d.qmd:5: the div id goes from #gradient-explorer-3d to #fig-gradient-explorer-3d.

  • Sibling pattern: The id now matches the sibling _fig-gradient-explorer.qmd, whose div is #fig-gradient-explorer. The fig- prefix makes Quarto treat the div as a cross-referenceable figure. The paragraph at the end of the div (line 73 onward) serves as its caption.
  • Inbound references: CLAUDE.md says #id anchors are an interface that course sites link to. I grepped the checkout and found no reference to the old gradient-explorer-3d id. The only other mention is the filename entry in .lintr.R, which is unaffected. I couldn't check external sites such as mlds, so the author should confirm none link to #gradient-explorer-3d. The widget is HTML-only and was newly added, so the risk is low.
  • Other checks: The diff has no math, no new prose, no R code, no _site/ or _freeze/ files and no bibliography changes, so there was nothing to check for macros, line breaks or build hygiene. I did not render the page.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "c82f07e6a61d0b1cf9f80a30e65cd0baa5720294",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The single changed line renames the div id in _fig-gradient-explorer-3d.qmd to fig-gradient-explorer-3d, matching the sibling figure; no in-repo references to the old id exist and the div already has a caption paragraph.",
  "holistic_assessment": "The change is minimal and in scope; the only residual risk is external course sites linking to the old anchor, which could not be checked from this repository."
}

Reviewed commit: c82f07e

@github-actions

github-actions Bot commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2286 (review) — run

@github-actions

github-actions Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-11-04 17:41 UTC

@dem-extra1
dem-extra1 merged commit 1e66680 into main Nov 4, 2026
43 of 44 checks passed

Copy link
Copy Markdown
Contributor Author

Merged on Ezra's "mwc". Cross-harness review waived: the one non-Claude route in this session (opencode.ai) was blocked by the auto-mode classifier, and no other CLI reviewer is installed. The checker exited 0 on head c82f07e, CI was green with the freeze cache bypassed, and the Claude review was clean.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clear freezer Re-render every page in the PR preview, ignoring the freeze cache

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants