Skip to content

Add a level-curve figure to the Newton quadratic example - #652

Merged
d-morrison merged 8 commits into
mainfrom
claude/mds646-newton-quadratic-fig
Nov 5, 2026
Merged

d-morrison merged 8 commits into
mainfrom
claude/mds646-newton-quadratic-fig

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Requested by Ezra · project thread

Part of #579; follows #647 and #648.

Adds fig-newton-quadratic inside #exm-newton-quadratic: the level curves of $f(\vx) = \tfrac{1}{2}(x_1^2 + 3x_2^2)$ with the start $(3, 1)$, the Newton step going straight to the minimizer, and the negative gradient (same length) missing it. The example's prose cites the figure.

Files: _subfiles/vector-calc/_fig-newton-quadratic.qmd (new), _subfiles/vector-calc/_exm-newton-quadratic.qmd.

Checked by rendering optimization-newton.qmd to HTML and viewing the R figure; the cross-reference resolves. The lms lint was not run locally.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pBmXswEX8Uu9Kt7f7
@d-morrison d-morrison self-assigned this Nov 5, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pBmXswEX8Uu9Kt7f7
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pBmXswEX8Uu9Kt7f7
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pBmXswEX8Uu9Kt7f7
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Contributor Author

Annotations reviewed: head 420bced. 43 are runner-image ubuntu-latest migration notices, plus one preview-diff element cap and one empty SUBMODULES_TOKEN note. Five are check warnings in other files (_subfiles/indicator-functions/_sec-indicator-functions.qmd, _subfiles/derivatives/_def-limit.qmd, _subfiles/_def-riemann-sum-equal-width.qmd, _subfiles/_def-partition.qmd, _subfiles/_def-continuous.qmd) that this PR does not change. The contour-without-3D warnings on this PR's figure are fixed by the 3D sibling figure.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


The merge of main doesn't change what this PR adds, so my earlier verdicts still stand. I read the saved diff but did not render the page or run any CI checks.

The prior round was the 2026-11-05 run on 420bced, which ended Ready for merge.

What changed: The only commit since is ce96dac, a merge of main into the branch. It matches git's automatic merge of its parents. It brings in three commits already on main: #650 (Sets moved to mcs), #653 (Functions moved to mcs), and #655 (the saddle-point example).

This PR's own diff: Against main it is still three files, with no change since the last clean round:

  • _subfiles/vector-calc/_fig-newton-quadratic.qmd
  • _subfiles/vector-calc/_fig-newton-quadratic-3d.qmd
  • _subfiles/vector-calc/_exm-newton-quadratic.qmd

Links into the moved page: #653 turned functions.qmd into a redirect stub that forwards to the mcs site. The stub's header says the ids did not change. The new functions.qmd#def-function and functions.qmd#def-graph links, at _exm-newton-quadratic.qmd:22 and _fig-newton-quadratic-3d.qmd:116, still work through that redirect. Other pages already link the same way, so I raise no finding.

Other checks: I found nothing new on the caption wording, cross-references, chunk options or macros.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "ce96dacf3f5f70502e315adbd5e164f57d925145",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The merge commit ce96dac matches git's automatic merge, and the three Newton quadratic subfiles are unchanged since the clean round; links to functions.qmd still reach mcs through the redirect stub.",
  "holistic_assessment": "The only new input is a merge of main (#650, #653, #655), so scope and regression risk are unchanged and the prior Ready for merge verdict still stands."
}

Reviewed commit: ce96dac

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2040 (review) — run

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/mds/pr-preview/pr-652/

Built to branch gh-pages at 2026-11-05 23:12 UTC.

Copy link
Copy Markdown
Contributor Author

Annotations reviewed: head ce96dac. All 45 are platform notices (43 runner-image ubuntu-latest migration notices, one preview-diff element cap, one empty SUBMODULES_TOKEN note); none points at this PR's files.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@d-morrison
d-morrison merged commit 9fe2748 into main Nov 5, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants