Skip to content

Move Proof Writing to mcs; leave a redirect stub - #661

Merged
dem-extra1 merged 6 commits into
mainfrom
claude/mcs60-phase5-proof-writing
Nov 6, 2026
Merged

dem-extra1 merged 6 commits into
mainfrom
claude/mcs60-phase5-proof-writing

Conversation

@dem-extra1

@dem-extra1 dem-extra1 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Part of Morrison-Lab/mcs#60 (phase 5, Proof Writing).

What changes

Pure moves and deletions:

  • proof-writing.qmd becomes a redirect stub to https://morrison-lab.github.io/mcs/proof-writing.html that keeps #ids.
  • The 119 _subfiles/proof-writing/ files and the host fragment _proof-writing.qmd are deleted; they live in mcs, including the page's Further reading list.
  • The navbar and sidebar entries, and the README and index tables, drop Proof Writing.

Link edits (a script confirmed all 17 distinct ids exist on the published page):

  • 35 files had their proof-writing links repointed to the mcs page, including the last two that still pointed at the stub (notation.qmd and _def-local-minimizer.qmd).

Edits the repoint forced, so the checks pass on the touched files:

  • 17 new subfiles: multi-div subfiles that the repoint touched are split one div per file, because the repo's one-div-per-subfile check reads whole files. Expanding the parents before and after gives the same text.
  • Term links on first uses the term check flagged on touched lines, and two reworded lines in the Moore-Penrose theorem and example (a trailing crossref became a link, and "moreover" became "and").

Checks run locally

  • The parent expansion comparison above, apart from the stub itself.
  • The pre-push check-term-links run passes.
  • No tracked file includes the deleted subfiles or fragment.

This is a pure move, so it exceeds the 10-file cap (pushed with ALLOW_LARGE_PR=1).

🤖 Generated with Claude Code

https://claude.ai/code/session_01FWgYrGcBYiCDELfrR89zk4

The 119 proof-writing subfiles now live in mcs. The page becomes a redirect stub that keeps #ids.
Every mds link to a proof-writing id now points at the mcs page; a script confirmed each id exists on the published page.
The host fragment and the navbar and sidebar entries go.

Part of Morrison-Lab/mcs#60

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrGcBYiCDELfrR89zk4
…ove touched

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrGcBYiCDELfrR89zk4
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

The moore-penrose theorem states its second claim with 'and' instead of 'moreover', and the example links least squares solution in place of a trailing crossref.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrGcBYiCDELfrR89zk4
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…k the term in the theorem

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrGcBYiCDELfrR89zk4
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

…ast stale links

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrGcBYiCDELfrR89zk4
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrGcBYiCDELfrR89zk4
@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I just fetched PR #661 live. It is open, not a draft and not merged, and the head is 23e34688aecba864e5189ae7b58c20224cb6dad8, the commit I reviewed.

The review stands as written: I found nothing new in the last two commits, and the prior Ready for merge verdict still holds.

Verdict

Ready for merge.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "23e34688aecba864e5189ae7b58c20224cb6dad8",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Commits 1369123 and 23e3468 split _def-local-minimizer.qmd into definition, remark and example files; ids def-global-minimizer and exr-local-vs-global-min resolve, the cubic example algebra checks out, and no stale proof-writing links remain.",
  "holistic_assessment": "The split preserves the original id and anchors, follows the one-div-per-subfile rule, adds the includes in the right order on the algebra basics page, and introduces no scope, macro, or regression concerns."
}

Reviewed commit: 23e3468

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.2601 (review) — run

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/mds/pr-preview/pr-661/

Built to branch gh-pages at 2026-11-05 23:51 UTC.

@dem-extra1
dem-extra1 merged commit d92a1d2 into main Nov 6, 2026
45 checks passed

dem-extra1 commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

Merged under Ezra's "mwc" (2026-11-06). Cross-harness review was waived: the OpenCode Go endpoint returned its monthly-limit error, and the codex, agy, gemini, cursor-agent and opencode CLIs are not installed in this session. Per Ezra's 2026-10-16 rule, a clean Claude CI review plus green CI plus this note stands in. The checker reported FULLY CLEAN on this head.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants