Repository navigation
Add a figure to the Newton maximum example - #663
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9pBmXswEX8Uu9Kt7f7
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9pBmXswEX8Uu9Kt7f7
Contributor
|
Claude finished review — View run Nothing blocking in this PR. I did not render the page, so the figure itself is unchecked. I checked these:
Suggestions (non-blocking)
VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "93c0694bd1ac25a2ff626a789500332e761736fe",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Checked _fig-newton-maximum.qmd: the plotted quadratic model, stationary point at -2.05 and maximum at -2 are numerically correct, and all linked def ids resolve.",
"holistic_assessment": "Small additive figure included once from the existing example; no regression, scope, or build-hygiene concerns, though the page was not rendered here."
}I fetched PR #663 just now. It is open, not a draft and not merged. Its head is VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "93c0694bd1ac25a2ff626a789500332e761736fe",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Checked _fig-newton-maximum.qmd: the plotted quadratic model, stationary point at -2.05 and maximum at -2 are numerically correct, and all linked def ids resolve.",
"holistic_assessment": "Small additive figure included once from the existing example; no regression, scope, or build-hygiene concerns, though the page was not rendered here."
}Reviewed commit: 93c0694 |
Contributor
Contributor
Built to branch |
Contributor
Author
|
Annotations reviewed: 93c0694 All are platform notices (the ubuntu-latest migration, an empty SUBMODULES_TOKEN, a diff-highlight cap); none concern this change. Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ezra · project thread
Adds a figure to
exm-newton-maximum: the cubic f(x) = x³/3 − 4x, its downward-opening quadratic model at the start −2.5, the model's stationary point −2.05, and the local maximum at −2. R (ggplot2) and Python (matplotlib) tabs; cited from and nested in the example.Part of #646 (figures for the optimization examples), under #579.
Files:
_subfiles/vector-calc/_fig-newton-maximum.qmd(new)_subfiles/vector-calc/_exm-newton-maximum.qmdRendered
optimization-newton.qmdlocally and checked both figures.Generated by Claude Code