Skip to content

Add a figure to the inflection point example - #670

Merged
d-morrison merged 2 commits into
mainfrom
claude/mds646-inflection-fig
Nov 6, 2026
Merged

d-morrison merged 2 commits into
mainfrom
claude/mds646-inflection-fig

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Requested by Ezra · project thread

Adds a figure to exm-inflection-point: f(x) = x³ and its second derivative 6x side by side, with the origin marked, where the second derivative changes sign. R (ggplot2) and Python (matplotlib) tabs, nested in and cited from the example.

Part of #646.

Files:

  • _subfiles/derivatives/_fig-inflection-point.qmd (new)
  • _subfiles/derivatives/_exm-inflection-point.qmd

Rendered optimization-critical-points.qmd locally and checked the R figure.


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pBmXswEX8Uu9Kt7f7
@d-morrison d-morrison self-assigned this Nov 6, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9pBmXswEX8Uu9Kt7f7
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I fetched PR 670 live just now. It is open, not merged, not a draft, and its head is 41641a2a62db3f92433723ed5de3ab56bd14bb8e, the commit I reviewed. The review above still applies.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "41641a2a62db3f92433723ed5de3ab56bd14bb8e",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The facet_wrap call in _fig-inflection-point.qmd now takes a pre-bound ggplot2::vars(fn) object, which removes the nested call and keeps the same faceting behaviour.",
  "holistic_assessment": "The change is a one-line lint-driven refactor that addresses the prior suggestion, touches no prose or math, and leaves the PR's scope and integration unchanged; linter and render were not run."
}

Reviewed commit: 41641a2

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1994 (review) — run

@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.2
🚀 Preview available at: https://Morrison-Lab.github.io/mds/pr-preview/pr-670/

Built to branch gh-pages at 2026-11-06 04:11 UTC.

Copy link
Copy Markdown
Contributor Author

Annotations reviewed: 41641a2

All are platform notices (the ubuntu-latest migration, an empty SUBMODULES_TOKEN, a diff-highlight cap); none concern this change.


Posted by Claude Code (AI agent) --- not written by a human.
Generated by Claude Code


Generated by Claude Code

@d-morrison
d-morrison merged commit 4bec67d into main Nov 6, 2026
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants