Repository navigation
Restore two drifts from the rme source: offset definition, Fubini-Tonelli link - #228
Merged
Merged
Conversation
…Tonelli link Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nh61VJUp2V6tGvtkZ3BZKF
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nh61VJUp2V6tGvtkZ3BZKF
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
|
Claude finished review — View run Same two edits as before; the merge matches git's automatic merge. Prior reviews: 6267c9a and e2c68ed. Both were Ready for merge, and both still stand. I checked the full diff against
No generated files, bibliography entries, or workflows are touched. I did not render the site. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "302fb2522b6ceea95ec16d4f74d83773dc95617b",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The Fubini-Tonelli link in the fubini-tonelli-expectations subfile and the rewritten def-offset in the distributions subfile are unchanged since the last reviewed commit, and the merge of main matches git's automatic result.",
"holistic_assessment": "The change is two scoped prose edits with no build artifact, bibliography, or workflow impact, so the earlier clean verdicts still stand."
}Reviewed commit: 302fb25 |
Contributor
Contributor
2026-10-19 21:31 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ezra · project thread
Before:
def-offsetdefined the offset only for a count outcome with exposure (rme defined it for any model term with no unknown coefficient).exm-fubini-prob-failnamed Fubini–Tonelli as plain text, where rme linked it.After:
def-offsetgives the general definition first (a term of the linear component with no unknown coefficient), then the count-model case, with the same equation and[@thm-exposure-log-scale]citation. The Fubini–Tonelli mention links to the mds theorem, as the other pds pages do.How: part of the drift audit tracked in Morrison-Lab/lds#1214. pds#8 was compared with rme at port time. These two differences were accidental, so the better version is used: the general rme definition combined with the pds count-model wording. Other differences in pds#8 are disclosed corrections and stay. I rendered
distributions.qmdto HTML and checked the new sentence.expectation.qmdwould not render here because the R packagedobsonis missing from this environment; its only change is one link.Generated by Claude Code