Skip to content

Restore two drifts from the rme source: offset definition, Fubini-Tonelli link - #228

Merged
d-morrison merged 3 commits into
mainfrom
claude/restore-ported-drift
Oct 19, 2026
Merged

d-morrison merged 3 commits into
mainfrom
claude/restore-ported-drift

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Requested by Ezra · project thread

Before: def-offset defined the offset only for a count outcome with exposure (rme defined it for any model term with no unknown coefficient). exm-fubini-prob-fail named Fubini–Tonelli as plain text, where rme linked it.

After: def-offset gives the general definition first (a term of the linear component with no unknown coefficient), then the count-model case, with the same equation and [@thm-exposure-log-scale] citation. The Fubini–Tonelli mention links to the mds theorem, as the other pds pages do.

How: part of the drift audit tracked in Morrison-Lab/lds#1214. pds#8 was compared with rme at port time. These two differences were accidental, so the better version is used: the general rme definition combined with the pds count-model wording. Other differences in pds#8 are disclosed corrections and stay. I rendered distributions.qmd to HTML and checked the new sentence. expectation.qmd would not render here because the R package dobson is missing from this environment; its only change is one link.


Generated by Claude Code

…Tonelli link

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Nh61VJUp2V6tGvtkZ3BZKF
@d-morrison d-morrison self-assigned this Oct 19, 2026
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Nh61VJUp2V6tGvtkZ3BZKF
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Same two edits as before; the merge matches git's automatic merge.

Prior reviews: 6267c9a and e2c68ed. Both were Ready for merge, and both still stand.

I checked the full diff against main (f54f6fd) for 302fb25. It touches only these two files:

  • _subfiles/_fubini-tonelli-expectations.qmd:212
    • The new link is to morrison-lab.github.io/mds/calculus-double-integrals.html#thm-fubini-tonelli.
    • The first round fetched that page and found the anchor.
  • _subfiles/_sec-distributions.qmd:593-603
    • The #def-offset div still defines one term, in bold, and keeps its title and anchor.
    • The [mean](expectation.qmd#def-expectation) link was verified in the second round.

No generated files, bibliography entries, or workflows are touched. I did not render the site.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "302fb2522b6ceea95ec16d4f74d83773dc95617b",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The Fubini-Tonelli link in the fubini-tonelli-expectations subfile and the rewritten def-offset in the distributions subfile are unchanged since the last reviewed commit, and the merge of main matches git's automatic result.",
  "holistic_assessment": "The change is two scoped prose edits with no build artifact, bibliography, or workflow impact, so the earlier clean verdicts still stand."
}

Reviewed commit: 302fb25

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1578 (review) — run

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-19 21:31 UTC

@d-morrison
d-morrison merged commit 468b964 into main Oct 19, 2026
25 checks passed
@d-morrison
d-morrison deleted the claude/restore-ported-drift branch October 19, 2026 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants