Skip to content

Use \posclass and \negclass instead of + and \neg + in Bayes' theorem diagnostic test example - #231

Merged
d-morrison merged 2 commits into
mainfrom
feat/posclass-negclass
Oct 20, 2026
Merged

d-morrison merged 2 commits into
mainfrom
feat/posclass-negclass

Conversation

@d-morrison

@d-morrison d-morrison commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Bumps latex-macros submodule to 9a65762d (origin/main, including Morrison-Lab/macros#256 adding \posclass and \negclass, along with intermediate upstream commits on main).
  • Updates _subfiles/_thm-bayes.qmd (#exm-bayes) and _subfiles/_sol-base-rate.qmd (#sol-base-rate) to use \posclass (+) and \negclass (-) instead of raw + and \neg + for positive and negative diagnostic test results.
  • Adds negclass and posclass to inst/WORDLIST.

Closes #230.

@d-morrison
d-morrison marked this pull request as ready for review October 20, 2026 19:26
@d-morrison

d-morrison commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor Author

Cross-Harness Adversarial Review (claude-cli, claude-opus-4-7)

Reviewed commit: 8d2b5f23bc1ceb5bacfe3ac2c21940e011ef8f33

Verdict: Clean

No actionable issues found. Submodule bump (latex-macros to 9a65762d), semantic macro replacements (\posclass and \negclass in _subfiles/_thm-bayes.qmd and _subfiles/_sol-base-rate.qmd), and minimal inst/WORDLIST additions (negclass, posclass) verified against probability-basics.qmd render and spelling::spell_check_package().


Posted by Antigravity (AI agent)

@github-actions

Copy link
Copy Markdown
Contributor

👀 Claude Review Dispatched — run reviewing PR #231 at 8d2b5f2.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Code review

I found no issues in this PR. I checked for bugs and CLAUDE.md compliance.

  • Macros exist at the bumped submodule commit. latex-macros moves to 9a65762, whose commit message is "Add \posclass and \negclass...". That commit defines \posclass and \negclass in latex-macros/interpretations.tsv and documents them in notation-choices.qmd.
  • No stray raw signs remain. A grep of _subfiles/_thm-bayes.qmd and _subfiles/_sol-base-rate.qmd for Pr(+ and \neg + found no leftovers. The \neg + form is now \negclass, which matches the guidance in notation-choices.qmd. Across the other .qmd files and _subfiles, no Pr(+ or mid +) remains.
  • Spell check is handled. negclass and posclass are added to inst/WORDLIST in alphabetical order, as CLAUDE.md requires.
  • Scope is tight. There are no changes to _site/, _freeze/ or .quarto/. No #id anchors changed, so links from other sites keep working.

I did not render the site.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "8d2b5f23bc1ceb5bacfe3ac2c21940e011ef8f33",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Checked _thm-bayes.qmd and _sol-base-rate.qmd: every positive and negative test sign now uses the new macros, and both macros are defined in the bumped latex-macros submodule commit.",
  "holistic_assessment": "The change is scoped to one notation migration plus wordlist and submodule bump, with no anchor renames, no build artifacts committed, and no regression risk found."
}

Reviewed commit: 8d2b5f2

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1455 (review) — run

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-20 21:23 UTC

@d-morrison
d-morrison merged commit fc1f913 into main Oct 20, 2026
33 checks passed
@d-morrison
d-morrison deleted the feat/posclass-negclass branch October 20, 2026 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use \posclass and \negclass instead of + and \neg + in Bayes' theorem diagnostic test example

1 participant