Skip to content

Bump latex-macros to the prediction-function and RSS/TSS release - #242

Merged
d-morrison merged 1 commit into
mainfrom
bump-macros-pin-16d943c
Oct 23, 2026
Merged

d-morrison merged 1 commit into
mainfrom
bump-macros-pin-16d943c

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Moves the latex-macros pin to 16d943c (macros#280 prints the prediction function as f, and macros#282 adds the RSS, TSS and training-count macros).

Part of ai-config#4673. The pin change is the whole diff.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Code review

PR #242 changes one line: it bumps the latex-macros submodule pointer from 564e6458 to 16d943c7. The submodule checkout already contains the new commit, 16d943c Print the prediction function as f, so the fitted one is f-hat (#280), and its object type is commit, so the pointer resolves.

  • Scope: Dependabot-style submodule updates are expected here (CLAUDE.md: "Dependabot auto-updates the latex-macros submodule"). The PR touches no .qmd, R, config, bibliography or build-artifact files.
  • Content risk: The bump changes how a prediction-function macro prints, with the fitted one shown as f-hat. I did not render the site or grep the pages for uses of that macro, so I can't rule out a visible change in a page that uses it.
  • Prior reviews: I had no prior review comments to compare against, and no earlier verdict applies.

No issues found. Checked for bugs and CLAUDE.md compliance.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "a35d538c3d7c29d238ee5c1183256567a3677fbb",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The only changed path is the latex-macros submodule pointer, and the target commit 16d943c exists in the submodule checkout, so there is no dangling-reference failure.",
  "holistic_assessment": "The change is scoped to the Dependabot-managed submodule bump with no regression, integration, or build-artifact concerns, though I did not render the site to check pages that use the changed macro."
}

Reviewed commit: a35d538

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1423 (review) — run

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-23 04:23 UTC

@d-morrison
d-morrison merged commit 1d0a90d into main Oct 23, 2026
27 checks passed
@d-morrison
d-morrison deleted the bump-macros-pin-16d943c branch October 23, 2026 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants