Repository navigation
Move commentary out of the squared-error risk definition - #246
Merged
Merged
Conversation
Fixes #245. The closing sentence relating the term to the risk moves to #rem-squared-error-risk-is-risk, included after the definition and its example. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JnPx8evH3UH3HERfjXrxht
Contributor
|
Claude finished review — View run The change is small and I found nothing to fix. It moves the one-line "it is the risk under squared error loss" sentence out of the Checks
Prior reviews of this PR: none were available to me, so there is nothing earlier to confirm. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "016e30f465f9a58530574091838093c4ce4cd6c8",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "Traced the new _rem-squared-error-risk-is-risk.qmd subfile and its include in expectation.qmd; the #def-risk and #def-squared-error-loss targets are defined earlier, so there are no forward references or broken anchors.",
"holistic_assessment": "The change splits one remark out of a definition div to satisfy the one-term-per-div and one-div-per-subfile rules; scope is minimal, no generated files or CI config are touched, and no regression risk was found."
}Reviewed commit: 016e30f |
Contributor
Contributor
2026-10-23 17:51 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #245.
A definition div holds the definition, notation and display equation; commentary goes in a
#rem-div (Morrison-Lab/sds#444 (comment)).#def-squared-error-riskloses its closing sentence ("It is the risk under squared error loss").#rem-squared-error-risk-is-risk, in its own subfile, included after the definition and its example (they share one file, so the remark cannot sit between them without splitting it).A scan of the other
_def-*files in pds found no further commentary.Checked locally: check-term-links is clean. No local render; please check the PR preview.
Owning thread: Bias is prediction error. Companion fixes: Morrison-Lab/sds#454 (merged), https://github.com/Morrison-Lab/lds/pull/1344 (merged).
Generated by Claude Code