Skip to content

Move commentary out of the squared-error risk definition - #246

Merged
d-morrison merged 1 commit into
mainfrom
claude/project-thread-n2luz6
Oct 23, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/project-thread-n2luz6

Conversation

@d-morrison

Copy link
Copy Markdown
Contributor

Fixes #245.

A definition div holds the definition, notation and display equation; commentary goes in a #rem- div (Morrison-Lab/sds#444 (comment)).

  • #def-squared-error-risk loses its closing sentence ("It is the risk under squared error loss").
  • The sentence moves to #rem-squared-error-risk-is-risk, in its own subfile, included after the definition and its example (they share one file, so the remark cannot sit between them without splitting it).
  • The definition's anchor is unchanged.

A scan of the other _def-* files in pds found no further commentary.

Checked locally: check-term-links is clean. No local render; please check the PR preview.

Owning thread: Bias is prediction error. Companion fixes: Morrison-Lab/sds#454 (merged), https://github.com/Morrison-Lab/lds/pull/1344 (merged).


Generated by Claude Code

Fixes #245. The closing sentence relating the term to the risk moves to
#rem-squared-error-risk-is-risk, included after the definition and its example.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JnPx8evH3UH3HERfjXrxht
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


The change is small and I found nothing to fix. It moves the one-line "it is the risk under squared error loss" sentence out of the #def-squared-error-risk div. It now sits in a new one-div subfile that the page includes straight after the definition.

Checks

  • One div per subfile: _subfiles/_rem-squared-error-risk-is-risk.qmd holds a single top-level #rem- div, so it meets the one-div-per-subfile rule. The rem- id prefix is the one the gha checks expect for remarks.
  • One term per definition div: _def-squared-error-risk.qmd now defines only the squared-error risk, with the cross-reference sentence gone.
  • Links and forward references: #def-risk and #def-squared-error-loss are both defined earlier in expectation.qmd (_def-risk.qmd and _def-loss-function.qmd), so there are no forward references. #def-squared-error-risk is defined immediately above the remark.
  • Include and anchors: the include at expectation.qmd:118 uses the repo's pds/_subfiles/... path convention and is followed by the usual slidebreak. #def-squared-error-risk keeps its id, so no external link breaks.
  • Style: the remark has no math, so the macro check does not apply. The .remark class follows existing usage in _def-pdf-pmf-cdf.qmd. The older _rem-risk-loss-exercise.qmd has no class, which this PR does not touch.
  • Build and CI: there are no changes to _site/, _freeze/, bibliography, workflows, or R code. I did not render the page or run any CI checks.

Prior reviews of this PR: none were available to me, so there is nothing earlier to confirm.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "016e30f465f9a58530574091838093c4ce4cd6c8",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Traced the new _rem-squared-error-risk-is-risk.qmd subfile and its include in expectation.qmd; the #def-risk and #def-squared-error-loss targets are defined earlier, so there are no forward references or broken anchors.",
  "holistic_assessment": "The change splits one remark out of a definition div to satisfy the one-term-per-div and one-div-per-subfile rules; scope is minimal, no generated files or CI config are touched, and no regression risk was found."
}

Reviewed commit: 016e30f

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1575 (review) — run

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-23 17:51 UTC

@d-morrison
d-morrison merged commit 9064774 into main Oct 23, 2026
30 of 31 checks passed
@d-morrison
d-morrison deleted the claude/project-thread-n2luz6 branch October 23, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move commentary out of #def-squared-error-risk

2 participants