Skip to content

Check code messages in pull requests - #270

Merged
dem-extra1 merged 4 commits into
mainfrom
claude/project-thread-yu0kbd-code-messages-ci
Oct 27, 2026
Merged

dem-extra1 merged 4 commits into
mainfrom
claude/project-thread-yu0kbd-code-messages-ci

Conversation

@dem-extra1

@dem-extra1 dem-extra1 commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Important

The check fails with "workflow not found" until the v3 tag of Morrison-Lab/gha slides past gha#1261. I will re-run it once the tag has moved.

Rendered code shows its output and nothing else (Ezra, 2026-10-26, lds#1440).
This PR adds a thin caller of the gha check-code-messages workflow.
The workflow flags a geom_smooth() or stat_smooth() call that does not name both method and formula, and a geom_histogram() or stat_bin() call with none of bins, binwidth or breaks, on lines a PR adds.
The workflow blocks (fail: true), and this PR touches no page.

Infrastructure only, in its own PR.


Generated by Claude Code

Rendered code shows its output and nothing else (Ezra, 2026-10-26).
Calls Morrison-Lab/gha's check-code-messages, which flags a geom_smooth() call
missing method or formula and a geom_histogram() call with no bins, binwidth or breaks.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ATp7JTApwjmgmaTS25Qrj5
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@dem-extra1

Copy link
Copy Markdown
Contributor Author

🤖 Antigravity agent report

Cross-harness review (Argon: Gemini 4 Argon (Medium) via Antigravity agy 1.3.5, read-only plan mode) at 4827d17

These come from the other model and I have not independently verified each one against the files, so treat them as leads. The review used the diff only (long diffs are truncated at 24000 characters); nothing was rendered.

Findings

  1. Pronoun referent shift in PR body:

It blocks (fail: true), and it touches no page.
The first "It" refers to the workflow (fail: true), while the second "it" switches referent mid-sentence to the pull request ("touches no page").

  1. Naked demonstrative pronoun in PR body:

This adds a thin caller of the gha check-code-messages workflow.
"This" is used without a head noun after a sentence about rendered code output; write "This PR adds...".

  1. Ambiguous pronoun and subjectless fragment in workflow header comment (.github/workflows/check-code-messages.yml:4-7):

# Flags a geom_smooth() or stat_smooth() call ... because ggplot2 prints a message under the chunk for each default.
# It is diff-scoped: it reads only the lines a PR adds.
Line 4 has no grammatical subject, leaving ggplot2 (or a message) as the nearest antecedent for It on line 7.

  1. PR description vs. workflow comment mismatch on flagged functions:

Body: It flags a geom_smooth() call ... and a geom_histogram() call ...
Diff: # Flags a geom_smooth() or stat_smooth() call ... and a geom_histogram() or stat_bin() call ...
The PR body omits stat_smooth() and stat_bin(), which the workflow header comment states are also flagged.

Verdict

VERDICT: FINDINGS

Reviewed-Commit: 4827d17

Posted by Claude Code (AI agent) --- not written by a human.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ATp7JTApwjmgmaTS25Qrj5
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ATp7JTApwjmgmaTS25Qrj5
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@dem-extra1

Copy link
Copy Markdown
Contributor Author

🤖 Antigravity agent report

Cross-harness review (Argon: Gemini 4 Argon (Medium) via Antigravity agy 1.3.5, read-only plan mode) at 3abd06b

Checked for correctness, Quarto syntax and crossrefs, consistency with the PR description, lost or duplicated content, and style, from the diff alone. Not checked: the rendered page.

Verdict

VERDICT: CLEAN

Reviewed-Commit: 3abd06b

Posted by Claude Code (AI agent) --- not written by a human.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


I found no new issues in this round.

The PR adds one file, .github/workflows/check-code-messages.yml. It is a thin caller of Morrison-Lab/gha's check-code-messages workflow.

  • Permissions: the caller grants contents: read. The reusable workflow's job declares only contents: read, so that is enough. This also satisfies the check-caller-permissions check that came in from main.
  • Trigger: pull_request only. That is right, because the check diffs against the PR base.
  • Since the last round: the only change is the merge of main (3c54bec). It matches git's automatic merge of its parents, and the eight base commits it brought in touch Mahalanobis and Bernoulli content and caller-permission checks, not this file.
  • Scope: the diff has no .qmd content, math, bibliography or build output. The content and macro checks don't apply.

I did not check that the @v3 tag exists. Other callers in this repo already use @v3.

The prior review of 3abd06b (comment) said Ready for merge, and that still stands.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "3c54bec0f2b4b5e93517cb71f84333bfcfe542ef",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The check-code-messages.yml caller grants contents: read, which matches the reusable workflow's job permissions, and uses a pull_request trigger with a valid fail input.",
  "holistic_assessment": "The only change since the last review is a clean merge of main, so the scoped single-file workflow addition and the prior Ready for merge verdict both stand."
}

Reviewed commit: 3c54bec

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1922 (review) — run

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-27 06:44 UTC

@dem-extra1
dem-extra1 merged commit 1ef9df8 into main Oct 27, 2026
30 checks passed
@dem-extra1
dem-extra1 deleted the claude/project-thread-yu0kbd-code-messages-ci branch October 27, 2026 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants