Skip to content

Add rule: state a theorem in one short sentence - #434

Merged
d-morrison merged 3 commits into
mainfrom
claude/project-thread-5ek13a
Oct 30, 2026
Merged

d-morrison merged 3 commits into
mainfrom
claude/project-thread-5ek13a

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Item 2 of psw#422; does not close it, since items 3 to 5 are separate.

Adds a section to chapters/mathematical-writing.qmd: a theorem statement is one short sentence, with introductions and motivation before it and asides ("without loss of generality", "moreover") left out. Halmos, "How to Write Mathematics", section 10, text read 2026-10-29. Includes a ❌/✅ example and notes the bib entry now covers sections 10, 11 and 15.

The warn-only check for the asides is gha#1368; it reaches psw once that merges and the v3 tag slides. Length cannot be checked mechanically, and the prose says so.

No sweep: existing statements are untouched.


Generated by Claude Code

Refs #422 item 2.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9rJ1dxeJYK1Rqeo1rp
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9rJ1dxeJYK1Rqeo1rp
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019xfc9rJ1dxeJYK1Rqeo1rp

Copy link
Copy Markdown
Collaborator Author

check / link-checker failed on a 503 from https://ucd-serg.github.io/lab-manual/resources.html, linked from chapters/intro.qmd and chapters/slides-posters-figures.qmd. This PR touches neither file, and the 503 comes from an outside host. I have re-run the failed job once. No fix exists to port yet, since the failure isn't in this PR's code.


Posted by Claude Code (AI agent) --- not written by a human.
Generated by Claude Code


Generated by Claude Code

@github-actions

Copy link
Copy Markdown

Claude finished review — View run


Verified both fixes from the prior round: git log 644eeed6..b59fb2cf shows a single content commit (7f69798) that touches only chapters/mathematical-writing.qmd, making exactly the two edits the prior review suggested, word-for-word:

  • chapters/mathematical-writing.qmd:47 now reads A warn-only check ([gha#1368](https://github.com/Morrison-Lab/gha/pull/1368)) flags "without loss of generality", "moreover" and "furthermore" on a line that a pull request adds to a theorem statement. I confirmed gha#1368 resolves and is merged — title "check-proof-statements: flag asides in a theorem statement" — matching the described behavior, so this isn't a fabricated citation. (Note: .github/workflows/ has no thin-caller check-proof-statements.yml yet, so the check isn't wired into psw's own CI; but the sentence only claims the check exists in gha, and this matches the house convention teaching.qmd already uses for other not-yet-wired gha checks, e.g. check-restated-results at teaching.qmd:41 and check-split-solutions at teaching.qmd:73 — neither has a local thin-caller either. Not a new issue.)
  • chapters/mathematical-writing.qmd:404-407 now reads as one continuous quotation — Halmos says that phrases such as "without loss of generality we may assume ..." and "moreover it follows from Theorem 1 that ..." do not belong in the statement of a theorem [@halmos1970write, section 10]. — resolving the dangling-fragment issue. The two lowercased quote-fragment starts ("without…", "moreover…") are normal, unbracketed mid-sentence integration of a quotation and don't change the quoted wording itself (unchanged from the already-verified quote content in the prior round).

No other lines in chapters/mathematical-writing.qmd or references.bib changed in this range, so there's nothing new to check in cross-references, the bib note, WORDLIST/spelling, or math-macro usage beyond what the prior round already verified.

I found no new issues in this round.

Verdict

Ready for merge — the prior round's two non-blocking suggestions are both addressed; see #434 (comment) for the full verified baseline, which still stands.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "b59fb2cf3ccdb0c03fa1ac5654fd97132194ef2e",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "chapters/mathematical-writing.qmd's warn-only-check sentence now cites gha#1368 (verified merged) and the Halmos quotation reads as one continuous span, resolving both prior-round prose findings with no new defect introduced.",
  "holistic_assessment": "The scope stays limited to the one new section plus its bib note, cross-references and citations still resolve, CI conventions match existing teaching.qmd precedent, and no regression or validation gap was found."
}

Reviewed commit: 7f69798

@github-actions

Copy link
Copy Markdown

💰 Cost: $0.4672 (review) — run

@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-30 01:13 UTC

@d-morrison
d-morrison merged commit 4aaaf95 into main Oct 30, 2026
25 of 26 checks passed
@d-morrison
d-morrison deleted the claude/project-thread-5ek13a branch October 30, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants