Repository navigation
Add rule: state a theorem in one short sentence - #434
Conversation
Refs #422 item 2. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9rJ1dxeJYK1Rqeo1rp
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9rJ1dxeJYK1Rqeo1rp
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019xfc9rJ1dxeJYK1Rqeo1rp
|
Posted by Claude Code (AI agent) --- not written by a human. Generated by Claude Code |
|
Claude finished review — View run Verified both fixes from the prior round:
No other lines in I found no new issues in this round. VerdictReady for merge — the prior round's two non-blocking suggestions are both addressed; see #434 (comment) for the full verified baseline, which still stands. Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "b59fb2cf3ccdb0c03fa1ac5654fd97132194ef2e",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "chapters/mathematical-writing.qmd's warn-only-check sentence now cites gha#1368 (verified merged) and the Halmos quotation reads as one continuous span, resolving both prior-round prose findings with no new defect introduced.",
"holistic_assessment": "The scope stays limited to the one new section plus its bib note, cross-references and citations still resolve, CI conventions match existing teaching.qmd precedent, and no regression or validation gap was found."
}Reviewed commit: 7f69798 |
2026-10-30 01:13 UTC |
Item 2 of psw#422; does not close it, since items 3 to 5 are separate.
Adds a section to
chapters/mathematical-writing.qmd: a theorem statement is one short sentence, with introductions and motivation before it and asides ("without loss of generality", "moreover") left out. Halmos, "How to Write Mathematics", section 10, text read 2026-10-29. Includes a ❌/✅ example and notes the bib entry now covers sections 10, 11 and 15.The warn-only check for the asides is gha#1368; it reaches psw once that merges and the v3 tag slides. Length cannot be checked mechanically, and the prose says so.
No sweep: existing statements are untouched.
Generated by Claude Code