Skip to content

Add cleanup-pr-previews workflow - #180

Merged
dem-extra1 merged 2 commits into
mainfrom
claude/qwt-cleanup-pr-previews
Oct 16, 2026
Merged

dem-extra1 merged 2 commits into
mainfrom
claude/qwt-cleanup-pr-previews

Conversation

@dem-extra1

Copy link
Copy Markdown
Contributor

Requested by Ezra · project thread

Before: qwt publishes PR previews to gh-pages through preview-deploy.yml but never removes them, so closed PRs' snapshots accumulate.

After: a weekly job deletes preview directories for PRs that are no longer open and, with compact-history: true, orphan-squashes gh-pages to one commit.

How: copied unchanged from rme. Note that compaction force-pushes gh-pages; that is the same behavior rme has.

Part of bringing qwt to parity with rme.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Pt2CCy6mttjwpefQ3bFBao


Generated by Claude Code

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Pt2CCy6mttjwpefQ3bFBao
Copilot AI balanced review requested due to automatic review settings October 16, 2026 07:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

This comment has been minimized.

@dem-extra1 dem-extra1 self-assigned this Oct 16, 2026

Copy link
Copy Markdown
Contributor Author

/review


Generated by Claude Code

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


No output confirms the file is byte-identical to what was reviewed in the last round (commit 6dcb7029). Everything else in the git log range between rounds (check-ai-tells, check-secrets, lint-workflows, etc.) came in via the merge-from-main commit dc799b0 — it's main-branch work, not part of this PR's diff, which still touches exactly the one file, unchanged.

The prior review already verified the reusable workflow reference, the v2 tag, the compact-history input, permissions, and the byte-for-byte match with rme's equivalent file — all still valid since nothing changed.

Review: PR #180 — Add cleanup-pr-previews workflow

What changed since the last review round: Nothing in the PR's own diff. The only commit added since 6dcb7029 is dc799b0 ("Merge branch 'main' into claude/qwt-cleanup-pr-previews"), which brought the branch up to date with main but did not modify .github/workflows/cleanup-pr-previews.yml — confirmed via git diff 6dcb7029 58342b5b -- .github/workflows/cleanup-pr-previews.yml, which produced no output.

The prior review (#180 (comment), posted 2026-10-16T09:02:35Z, run https://github.com/Morrison-Lab/qwt/actions/runs/38877429500) concluded Ready for merge with no findings, having verified:

  • the reusable workflow Morrison-Lab/gha/.github/workflows/cleanup-pr-previews.yml@v2 and its compact-history input exist and are real
  • v2 is a currently-maintained tag, consistent with this repo's per-workflow pinning convention
  • the file is byte-identical to rme's equivalent
  • preview-dir default matches the existing preview pipeline convention
  • caller permissions (contents: write, pull-requests: read) match exactly what the reusable workflow needs
  • the gh-pages branch exists as a real target
  • YAML parses cleanly

That verdict still stands — the diff under review is unchanged.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "58342b5b75f897ef6675d572e00701d46d4022ec",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The only changed path, .github/workflows/cleanup-pr-previews.yml, is byte-identical between commit 6dcb7029 and current head 58342b5b, so no new defect surface was introduced by the merge commit.",
  "holistic_assessment": "The merge from main brought in unrelated workflow additions without altering this PR's scope, integration points, or permissions, so the prior clean validation of requirements and regression risk still applies."
}

Reviewed commit: dc799b0

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1857 (review) — run

@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-16 09:40 UTC

@dem-extra1
dem-extra1 merged commit fe22cd5 into main Oct 16, 2026
26 checks passed
@dem-extra1
dem-extra1 deleted the claude/qwt-cleanup-pr-previews branch October 16, 2026 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants