Skip to content

Drop the dead _typos.toml line from the preview paths filter - #192

Merged
d-morrison merged 1 commit into
mainfrom
claude/project-thread-x3kyq1
Oct 23, 2026
Merged

d-morrison merged 1 commit into
mainfrom
claude/project-thread-x3kyq1

Conversation

@d-morrison

Copy link
Copy Markdown
Collaborator

Requested by Ezra · project thread

Closes #191.

Removes '!_typos.toml' from the paths: filter in preview.yml. It was copied from lds; this repo has no _typos.toml (spell check uses inst/WORDLIST), so the line never matched. Follow-up to #190.

Checked: the workflow parses as YAML.


Generated by Claude Code

This repo has no _typos.toml, so the line never matched.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017pUEtVkshG1L3gzWbe2jCj
Copilot AI balanced review requested due to automatic review settings October 23, 2026 09:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@d-morrison d-morrison self-assigned this Oct 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Confirmed: no _typos.toml exists in the repo (spell-checking uses inst/WORDLIST per .github/workflows/check-spelling.yaml), so the removed '!_typos.toml' exclusion line was indeed dead weight — it could never have mattered to the paths: filter. The PR-head version of preview.yml shown above confirms the line is cleanly gone with the rest of the filter untouched and syntactically valid YAML (a plain list of path globs).

Checks performed:

  • Diff is a single-line removal, scoped exactly as described in the PR body.
  • No _typos.toml anywhere in the tree, confirming the line was unreachable/dead.
  • Fetched the actual PR-head preview.yml (not the restored default-branch copy) and confirmed the YAML still parses as a valid list and the surrounding negation patterns (!.claude/**, !*.md, !.gitignore, !.gitattributes) are untouched and correctly ordered.
  • No other files changed; nothing else in the diff to review.
  • Checked PR comments: none exist yet, so this is the first review round.

This is a trivial, well-scoped cleanup with an accurate description, no CLAUDE.md violations (no R code, no .qmd content, no new dependencies), and no risk to the preview/publish pipeline since the removed line was never matching anything either way.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "bce48e9307c303b5e0e841a0cfe94b737b24535b",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "Verified .github/workflows/preview.yml no longer references the nonexistent _typos.toml exclusion and the remaining paths filter stays valid YAML.",
  "holistic_assessment": "Single-line dead-path removal has no integration, regression, or scope impact on the preview or publish pipelines."
}

Reviewed commit: bce48e9

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.1472 (review) — run

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-23 18:15 UTC

@d-morrison
d-morrison merged commit 3de5304 into main Oct 23, 2026
24 checks passed
@d-morrison
d-morrison deleted the claude/project-thread-x3kyq1 branch October 23, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop the dead _typos.toml line from the preview paths filter

3 participants