Repository navigation
Call the equation-render check at @v3 - #1403
Merged
Merged
Conversation
…f networkidle The @v2 line is frozen and still has the networkidle page-load timeout that fails Check Equation Renders on large pages (gha#1150, fixed in gha#1151, now in v3). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N1D6wprqV3LST2CCm76Mwv
Contributor
|
Claude finished review — View run Review: #1403 — Call the equation-render check at @V3Scope: single-line change in Verification performed
CLAUDE.md / lab-manual compliance
FindingsNone. This is a minimal, well-documented, independently-verified infrastructure fix. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "edf06305b5210549d8678a0b3f4d91ddf3947595",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The single-line change in .github/workflows/check-equation-renders.yml bumps a pinned reusable-workflow tag from v2 to v3, and diffing those tags confirms the v3 action.yml and permissions are unchanged while check_equations.mjs gained the documented load/retry fix.",
"holistic_assessment": "The PR stays scoped to infrastructure per the dedicated-PR rule, introduces no permission widening or content regression, and the workflow_run trigger behavior means no validation run occurs on this branch itself."
}Reviewed commit: edf0630 |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
Check Equation Renderscalled the gha reusable workflow at@v2, the frozen maintenance line. Its crawl waits fornetworkidlewith a 30 s timeout, so large pages intermittently fail withpage.goto: Timeout 30000ms exceeded, unrelated to any equation (Morrison-Lab/gha#1150).After: the workflow calls
@v3, which carries the fix (Morrison-Lab/gha#1151, now at thev3tag): the crawl waits forloadand retries a failed page load once.How: one line in
.github/workflows/check-equation-renders.yml. Thev3workflow requests the same permissions (contents: read,actions: read) and inputs, andaudit_callee_permissions.pyfound no widening between the old and newv3.workflow_runtriggers only fire for workflow files on the default branch, so this check will not run on this PR.Infrastructure only; no lecture content.
Generated by Claude Code