Skip to content

Call the equation-render check at @v3 - #1403

Merged
dem-extra1 merged 1 commit into
mainfrom
claude/project-thread-f3mz1v
Oct 22, 2026
Merged

dem-extra1 merged 1 commit into
mainfrom
claude/project-thread-f3mz1v

Conversation

@dem-extra1

Copy link
Copy Markdown
Collaborator

Before: Check Equation Renders called the gha reusable workflow at @v2, the frozen maintenance line. Its crawl waits for networkidle with a 30 s timeout, so large pages intermittently fail with page.goto: Timeout 30000ms exceeded, unrelated to any equation (Morrison-Lab/gha#1150).

After: the workflow calls @v3, which carries the fix (Morrison-Lab/gha#1151, now at the v3 tag): the crawl waits for load and retries a failed page load once.

How: one line in .github/workflows/check-equation-renders.yml. The v3 workflow requests the same permissions (contents: read, actions: read) and inputs, and audit_callee_permissions.py found no widening between the old and new v3. workflow_run triggers only fire for workflow files on the default branch, so this check will not run on this PR.

Infrastructure only; no lecture content.


Generated by Claude Code

…f networkidle

The @v2 line is frozen and still has the networkidle page-load timeout
that fails Check Equation Renders on large pages (gha#1150, fixed in
gha#1151, now in v3).

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01N1D6wprqV3LST2CCm76Mwv
@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Review: #1403 — Call the equation-render check at @V3

Scope: single-line change in .github/workflows/check-equation-renders.yml, bumping the pinned tag for the reusable workflow call from Morrison-Lab/gha/.github/workflows/check-equation-renders.yml@v2 to @v3. No .qmd/.R/content changes.

Verification performed

  • gha#1150 (networkidle timeout issue) exists, is closed, and its description matches the PR body's summary exactly, including the cited failing-run links.
  • gha#1151 (the fix PR) exists, is merged (merged at 2026-10-22T08:48:58Z), and its diff touches check-equation-renders/check_equations.mjs — confirmed by diffing the v2 and v3 tags directly: v2 uses page.goto(..., { waitUntil: 'networkidle' }) with no retry; v3 uses waitUntil: 'load' inside a retry loop (PAGE_LOAD_ATTEMPTS), matching the PR's description precisely.
  • check-equation-renders/action.yml is byte-identical between v2 and v3 — no new permissions or inputs introduced, consistent with the PR body's claim that audit_callee_permissions.py found no widening. (I couldn't locate that script in the gha repo at any of the common paths, so it's likely an ad hoc/scratch script rather than a committed tool — but the underlying claim it produced is independently verified true, so this isn't a hallucination worth blocking on.)
  • The caller workflow (.github/workflows/check-equation-renders.yml in v2/v3 of gha) requests the same contents: read / actions: read permissions and the same fail input in both tags — matches this PR's unchanged permissions: block.
  • The claim that workflow_run triggers only fire for workflow files already on the default branch (so this check won't execute on this PR itself) is correct per GitHub Actions' documented behavior for workflow_run.
  • No prior review comments exist on this PR (fresh thread).

CLAUDE.md / lab-manual compliance

  • "Workflow / .github/ / CI / infra changes go in their own dedicated PRs — never mix them with book-content PRs" — satisfied; this PR touches only the workflow file.
  • Pre-commit checklist (quarto render / lintr / spell-check) is scoped to .qmd/.R/content changes and doesn't meaningfully apply to a CI version bump; not a concern here.
  • No LaTeX math in the diff, so the macro-opportunity check (latex-macros/macros.qmd, vendored via the d-morrison/macros submodule per .gitmodules) doesn't apply.
  • No AI-hallucinated APIs/paths found — all referenced artifacts (issue, PR, tags, action.yml, workflow file) resolve and match the description.

Findings

None. This is a minimal, well-documented, independently-verified infrastructure fix.

Verdict

Ready for merge

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "edf06305b5210549d8678a0b3f4d91ddf3947595",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The single-line change in .github/workflows/check-equation-renders.yml bumps a pinned reusable-workflow tag from v2 to v3, and diffing those tags confirms the v3 action.yml and permissions are unchanged while check_equations.mjs gained the documented load/retry fix.",
  "holistic_assessment": "The PR stays scoped to infrastructure per the dedicated-PR rule, introduces no permission widening or content regression, and the workflow_run trigger behavior means no validation run occurs on this branch itself."
}

Reviewed commit: edf0630

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.3163 (review) — run

@dem-extra1
dem-extra1 merged commit 335a255 into main Oct 22, 2026
28 checks passed
@dem-extra1
dem-extra1 deleted the claude/project-thread-f3mz1v branch October 22, 2026 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants