Repository navigation
Check that workflow callers grant the permissions their reusable workflows need - #1417
Conversation
…flows need Calls the gha check-caller-permissions workflow (v3). A caller job that omits a permission its callee's jobs request fails at startup with no log, as lds's preview cleanup did for a week (Morrison-Lab/lds#1468). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dmqa3hWsgjovnGyT7qANYK
The new check-caller-permissions guard found callers that omit a permission their callee's jobs request, which fails the call at startup. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dmqa3hWsgjovnGyT7qANYK
🤖 Antigravity agent reportCross-harness review (Argon: Gemini 4 Argon (Medium) via Antigravity
|
Run against the refs these callers pin, the check reports no missing grant, so the added permissions were speculative. Granting more than a callee requests is harmless but unexplained, so they come out of this PR. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dmqa3hWsgjovnGyT7qANYK
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Dmqa3hWsgjovnGyT7qANYK
|
Claude finished review — View run Review of #1417Summary: Adds Verification performed:
CLAUDE.md / lab-manual compliance:
No bugs, security issues, or convention violations found. VerdictReady for merge Structured Review Data (JSON){
"schema_version": "1.1",
"reviewer": "claude",
"commit_sha": "d75ad56f035abbe179ca9d9558773bf2f4bde5af",
"verdict": "CLEAN",
"findings": [],
"detailed_assessment": "The sole changed path, .github/workflows/check-caller-permissions.yml, mirrors check-dependency-graph.yml's established caller pattern exactly and grants only the contents:read permission its pinned v3 callee actually requests, so no permission-mismatch or syntax defect exists.",
"holistic_assessment": "Scope stays confined to infra per the dedicated-PR requirement, integration with the pinned Morrison-Lab/gha v3 reusable workflow and action is verified live, and CI on this exact head already passed both check-caller-permissions and lint-workflows, satisfying validation."
}Reviewed commit: d75ad56 |
🤖 Antigravity agent reportCross-harness review (Argon: Gemini 4 Argon (Medium) via Antigravity
|
Adds a caller for gha's
check-caller-permissionsworkflow (@v3). It fails a pull request when a job calls aMorrison-Lab/ghareusable workflow without granting the permissions the callee's jobs request. GitHub rejects such a call at startup with no log, as it did for lds's preview cleanup (Morrison-Lab/lds#1468).Correction: an earlier revision also added permission grants and said the check found them missing. That came from running the check against gha
main, not the refs this repository pins. At the pinned refs the check reports no missing grant, so those grants are removed.🤖 Generated with Claude Code
https://claude.ai/code/session_01Dmqa3hWsgjovnGyT7qANYK