Skip to content

Rename irreducible error to residual variance - #1420

Merged
dem-extra1 merged 5 commits into
mainfrom
claude/project-thread-3pt2z3
Oct 28, 2026
Merged

dem-extra1 merged 5 commits into
mainfrom
claude/project-thread-3pt2z3

Conversation

@dem-extra1

@dem-extra1 dem-extra1 commented Oct 27, 2026 •

Copy link
Copy Markdown
Collaborator

Requested by Ezra · project thread

Important

Morrison-Lab/sds#492 (Morrison-Lab/sds#492) has to land and publish first. The link here reads "residual variance" and points at the sds definition, which carries that title only after #492 deploys.

Companion to Morrison-Lab/lds#1482 (https://github.com/Morrison-Lab/lds/pull/1482, issue https://github.com/Morrison-Lab/lds/issues/1481).

What changed

  • The prediction-variance section names the future observation's noise variance the residual variance, irreducible given $\vxs$, and links the statistics notes' definition.
  • "Irreducible noise" in the prediction-interval sentence becomes "the noise".

Checks

  • check-term-links and check-new-line-breaks pass locally against origin/main. typos is clean. No issue was filed in this repository.

🤖 Generated with Claude Code

https://claude.ai/code/session_01FWgYrFWav9LSV68cg2qGzX

It is a variance, not an error, and it is irreducible only given the inputs.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFWav9LSV68cg2qGzX
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFWav9LSV68cg2qGzX
@dem-extra1 dem-extra1 self-assigned this Oct 27, 2026
@dem-extra1

Copy link
Copy Markdown
Collaborator Author

🤖 Antigravity agent report

Cross-harness review (Argon: Gemini 4 Argon (Medium) via Antigravity agy 1.3.5, read-only plan mode) at 402376f

These come from the other model and I have not independently verified each one against the files, so treat them as leads. The review used the diff only (long diffs are truncated at 24000 characters); nothing was rendered.

Findings

  1. Appositive comma splice / awkward double "the" phrasing in _subfiles/Linear-models-overview/_sec_linreg_prediction.qmd:

- $\Var{\eps^*} = \sigma^2$: the variance of the future observation's own noise, the [residual variance](https://morrison-lab.github.io/sds/model-validation.html#def-irreducible-error), which is irreducible given $\vxs$.
Stacking two "the ..." noun phrases after the colon ("the variance of ..., the residual variance, which is...") reads awkwardly and obscures whether "which is irreducible given $\vxs$" modifies the variance or the noise; consider the [residual variance](...) (the variance of the future observation's own noise, which cannot be reduced given $\vxs$). or the variance of the future observation's own noise (the [residual variance](...), which is irreducible given $\vxs$).

  1. Two sentences on one source line (semantic line breaks) in _subfiles/Linear-models-overview/_sec_linreg_prediction.qmd:

+the [residual variance](https://morrison-lab.github.io/sds/model-validation.html#def-irreducible-error), which is irreducible given $\vxs$.
While not two full periods, this line adds multiple clauses onto a single line instead of breaking at the comma/clause boundary to match the surrounding one-clause-per-line formatting (lines 66–67).

Verdict

VERDICT: FINDINGS

Reviewed-Commit: 402376f

Posted by Claude Code (AI agent) --- not written by a human.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFWav9LSV68cg2qGzX
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FWgYrFWav9LSV68cg2qGzX
@dem-extra1

Copy link
Copy Markdown
Collaborator Author

🤖 Antigravity agent report

Cross-harness review (Argon: Gemini 4 Argon (Medium) via Antigravity agy 1.3.5, read-only plan mode) at ad8b438

Checked for correctness, Quarto syntax and crossrefs, consistency with the PR description, lost or duplicated content, and style, from the diff alone. Not checked: the rendered page.

Verdict

VERDICT: CLEAN

Reviewed-Commit: ad8b438

Posted by Claude Code (AI agent) --- not written by a human.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link
Copy Markdown
Collaborator Author

I added the "clear freezer" label, since the PR edits a _subfiles/ file. The remaining red require-clean-verdict is the known merge-order hold on Morrison-Lab/sds#492 (Morrison-Lab/sds#492): this PR links the sds definition as "residual variance", and the deployed sds page changes only after #492 publishes. I will ask for a re-review once it is live.


Posted by Claude Code (AI agent) --- not written by a human.
Generated by Claude Code


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

/review

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

/review

sds#492 has merged and published, so the "residual variance" link now matches the live sds definition. The earlier finding about the missing "clear freezer" label is resolved: the label has been added. Requesting a fresh review on this head.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

Copy link
Copy Markdown
Collaborator Author

/review

The earlier review request on this head produced no new review. The "clear freezer" label is now on the PR and the sds definition is published as "residual variance". Requesting a fresh review on ad8b438.

Posted by Claude Code (AI agent) --- not written by a human.


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Claude finished review — View run


Both anchors exist on the live pages (unchanged from the prior review, which already confirmed these — only the sds residual-variance one was pending). No further verification needed there since these two links weren't flagged as problems before and nothing in the diff touching them has changed.

Since the PR's own file content is byte-identical to what was reviewed in the last round (confirmed via git diff producing no output between ad8b4384 and the current head ed66d79 for that file), and the only commits since then are routine main-merges plus CI/label updates, there is nothing new to review in the diff itself.

Review: Morrison-Lab/rme PR #1420 — "Rename irreducible error to residual variance"

PR status confirmed: open, not merged, not a draft (state: OPEN, mergeable: MERGEABLE).

What changed since the last review round

The content diff of the PR's only changed file, _subfiles/Linear-models-overview/_sec_linreg_prediction.qmd, is unchanged since the last-reviewed commit ad8b4384 — git diff ad8b4384 ed66d79 -- _subfiles/Linear-models-overview/_sec_linreg_prediction.qmd is empty. The commits in the computed range (971c4a3, 6245e25, c53514d, a172d65, 0e2cca2, 0fc45fc, plus the merge commits) are all routine main→branch merges picking up unrelated work (OR-RR.qmd axis-title fixes, hers-mle-app.qmd, binom.likelihood.app.qmd, a latex-macros submodule bump) and do not touch this PR's own file. This matches the CLAUDE.md requirement to merge main into the feature branch before pushing/requesting review.

Prior findings — now resolved

The prior review (posted 2026-10-27T08:54:49Z, run) raised two findings, both of which I independently re-verified as resolved:

  1. "clear freezer" label — now present on the PR (gh pr view shows labels: [{"name": "clear freezer"}]). ✅ Resolved.
  2. "residual variance" link target — Morrison-Lab/sds#492 merged 2026-10-27T17:45:40Z and is now published. I fetched the live page directly: https://morrison-lab.github.io/sds/model-validation.html#def-irreducible-error now renders <strong>Definition 37 (Residual variance)</strong>, matching this PR's link text exactly, with "irreducible error" retained parenthetically as the alias. ✅ Resolved.

The author's own /review comments (2026-10-28T18:05 and 20:11) independently report the same resolution, which my direct verification confirms rather than merely takes on faith.

No new issues were introduced in this range — the content is identical to the already-reviewed, already-correct wording change, and both blocking process items are now cleared. CI checks visible at review time (check-term-links, check-new-line-breaks, lint-changed-files, link-checker, check-dependency-graph, check-chars, check-orphans, CodeQL, etc.) all show pass; a few jobs (Spellcheck, build, check-dois, review/claude-review) were still pending at the time of this check — these should be confirmed green before merge, but nothing in their scope is expected to be affected by this unchanged, prose-only diff.

Verdict

Ready for merge — the prior round's two findings (missing "clear freezer" label, and the "residual variance" link pointing to a not-yet-renamed anchor) are both independently confirmed resolved; no new issues found in the unchanged diff.

Structured Review Data (JSON)
{
  "schema_version": "1.1",
  "reviewer": "claude",
  "commit_sha": "ed66d79d0a02f525407075f2f52e22136f62a282",
  "verdict": "CLEAN",
  "findings": [],
  "detailed_assessment": "The sole changed path, _subfiles/Linear-models-overview/_sec_linreg_prediction.qmd, is byte-identical to the previously reviewed version, so no new defect surfaced in this range.",
  "holistic_assessment": "Both prior blocking requirements, the clear-freezer label and the sds#492 publish dependency for the residual-variance link target, are independently confirmed resolved against live sources."
}

Reviewed commit: ed66d79

@github-actions

Copy link
Copy Markdown
Contributor

💰 Cost: $0.3673 (review) — run

@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.

2026-10-28 22:25 UTC

@dem-extra1
dem-extra1 merged commit 19b747f into main Oct 28, 2026
29 checks passed
@dem-extra1
dem-extra1 deleted the claude/project-thread-3pt2z3 branch October 28, 2026 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants