examples(oglo_tactile): package under isaacteleop_examples - #1042
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 12 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe OGLO tactile example now defines an installable package with core dependencies and an optional CUDA 12 GPU extra. Its recording module uses package-relative imports and updated plugin path resolution for source and installed layouts. The README installs the example through Priority: ➖ Normal Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The OGLO example's documented installation and module execution paths remain compatible, with optional GPU failures limited to the overlay. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
52c2c49 to
49cfeb2
Compare
49cfeb2 to
0289283
Compare
0289283 to
9c39d3a
Compare
9c39d3a to
50a02a5
Compare
50a02a5 to
3535522
Compare
ivany-nv
left a comment
There was a problem hiding this comment.
Read the diff line by line. Two changes beyond the move: the oglo_heatmap import becoming relative, and here.parents[2] becoming here.parents[5]. Checked the arithmetic — from python/isaacteleop_examples/oglo_tactile/, the repo root is five parents up, so that is right, and the comment about an installed copy falling through to the PATH lookup matches the code.
Not installed by install_python_example() and I have no OGLO hardware here, so nothing to run.
3535522 to
b6c1cb7
Compare
b6c1cb7 to
78ca635
Compare
78ca635 to
c6be03e
Compare
c6be03e to
b6f7a5e
Compare
b6f7a5e to
1091d9c
Compare
1091d9c to
391f883
Compare
391f883 to
e3693eb
Compare
e3693eb to
f1bbbd1
Compare
f1bbbd1 to
b9b7e19
Compare
b9b7e19 to
3a0d911
Compare
3a0d911 to
3850c8a
Compare
3850c8a to
0dc9a0a
Compare
oglo_teleop_record.py imported oglo_heatmap as a top-level module, which resolved only because the invoked script's own directory landed on sys.path. Move the tree to the layout in examples/README.md. The example gains its first pyproject.toml, so the README's `pip install pillow numpy` / `pip install cupy-cuda12x` become an install of the example and its `gpu` extra. cupy stays optional: without it the renderer still writes PNGs and only the in-headset overlay is lost. The plugin-binary probe walked up parents[2] to the repo root, which after the move points at the example's python/ directory. Now parents[5], with a note that it only resolves in a source checkout -- an installed copy lands in site-packages, where the existing PATH fallback takes over. Part of #985. Signed-off-by: Jiwen Cai <jiwenc@nvidia.com>
0dc9a0a to
b56095b
Compare
Description
Part of #985. Stacked on #1041.
oglo_teleop_record.pyimportedoglo_heatmapas a top-level module, which resolved only because the invoked script's own directory landed onsys.path. This moves the tree to the layout inexamples/README.md.The example gains its first
pyproject.toml, so the README's loosepip install pillow numpy/pip install cupy-cuda12xbecome an install of the example and itsgpuextra.cupystays optional — without it the renderer still writes PNGs and only the in-headset overlay is lost.One path fix the move forces.
_default_plugin_bin()walked upparents[2]to the repo root; three levels deeper that lands on the example'spython/directory. It is nowparents[5], with a note that it only resolves from a source checkout — an installed copy lands insite-packages, where the existing PATH fallback takes over.Type of change
Testing
x86_64/ Ubuntu, Python 3.12. Wheel ships both modules underisaacteleop_examples/oglo_tactile/with no namespace__init__.py. Editable-installed into a clean venv, both import with the CWD outside the repo;import oglo_heatmapfails.parents[5]verified to land on the repo root.pre-commitclean.Not covered: nothing here has an OGLO glove. The dependency list is inferred from imports and this example never had one before, so a missing runtime dep would only show on the machine with the gloves attached.
Checklist
SKIP=check-copyright-year pre-commit run --all-filesgit commit -s) per the DCONo tests: this is a move, and no CI has the hardware.
Summary by CodeRabbit
New Features
Bug Fixes