Skip to content

Degrade retrieval to test CI gate #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NaveenBuidl wants to merge 2 commits into from
Closed

Degrade retrieval to test CI gate #8

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0951f46
Degrade retrieval to test CI gate
NaveenBuidl Apr 9, 2026
b2dc217
Further degrade retrieval to force CI gate failure
NaveenBuidl Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
corpus_path: "D:/Evalens/corpus/intercom_external/raw_md"
chunk_size: 1000
chunk_overlap: 150
retrieval_k: 4
# retrieval_k: 4
retrieval_k: 0
Comment on lines +4 to +5

Copilot AI Apr 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting retrieval_k: 0 is likely to make retrieval invalid: app/rag.py passes this directly as n_results to Chroma’s collection.query, which commonly requires n_results >= 1 and may raise at runtime (failing CI for a crash rather than an eval-quality regression). If the goal is to degrade quality while keeping the pipeline valid, set this to 1 instead; if the goal is to test invalid config handling, consider adding explicit validation (fail fast with a clear error) rather than relying on downstream library behavior.

Copilot uses AI. Check for mistakes.
model: "llama-3.1-8b-instant"
embedding_model: "sentence-transformers/all-MiniLM-L6-v2"
chroma_path: ".chroma"
Expand Down
Loading