Repository navigation
Add THOR 10 to 11 migration guide - #220
phantinuss wants to merge 12 commits into
Conversation
| This chapter helps THOR 10 users prepare for an upgrade to THOR 11. | ||
| It focuses on changes that affect existing scan configurations, | ||
| command lines, log processing, Thunderstorm integrations, and resource | ||
| planning. The other chapters in this manual describe THOR 11. |
There was a problem hiding this comment.
That last sentence sounds superfluous. This is the THOR 11 manual, so this should be obvious.
| On Windows, use ``thor-util.exe``; on Linux and macOS, use | ||
| ``./thor-util`` when running the utility from its directory. |
There was a problem hiding this comment.
Is this necessary? ./thor-util will work even on Windows. Also, it's inconsistent: the download example uses Windows as normal case and Unix as "for others, do this", here it's reversed.
| active when you start THOR 11. THOR 11 prints a command-line message | ||
| when it detects an old configuration. Review that message and migrate | ||
| the settings before using the installation for regular scans. |
There was a problem hiding this comment.
thor-util does this during upgrade, but THOR 11 does not do so. It would be good IMO, though.
There was a problem hiding this comment.
I was under the impression we have some checks for cases such as "max_file_size_intense"/very low file sizes in place? We discussed the "old config" warning and decided against it in favour of general warnings if potential miss-configuration is detected. But yes the claim here is false.
| You can check whether your THOR Util version supports the reset option | ||
| with ``thor-util upgrade --help``. For general upgrade and package | ||
| selection options, see the | ||
| `THOR Util manual <https://thor-util-manual.nextron-systems.com/en/latest/usage/upgrade-and-updates.html>`__. |
There was a problem hiding this comment.
reinitialization instead of reset might be easier to understand.
Also: This doesn't help the customer on what to do if it isn't supported.
Co-authored-by: phantinuss <79651203+phantinuss@users.noreply.github.com>
ed0497f to
e6aa5af
Compare
e6aa5af to
efe07af
Compare
e13be6c to
686f9d6
Compare
There was a problem hiding this comment.
🟡 Changes recommended
Migration guidance conflicts with existing documentation on Thunderstorm availability, reporting thresholds, and CPU defaults.
3 open findings
What changed in this PR
Adds a THOR 10-to-11 migration guide covering configuration, logging, integrations, and resource planning.
Changes:
- Documents upgrade, downgrade, and compatibility considerations.
- Links the guide from the core contents and maintenance chapter.
- Standardizes “TechPreview” capitalization in the changelog heading.
| File | Description |
|---|---|
| core/upgrade-to-thor11.rst | Adds the migration guide. |
| core/maintenance.rst | Links to migration instructions. |
| core/index.rst | Adds the guide to the contents. |
| changelog/11.rst | Corrects heading capitalization. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| THOR Thunderstorm is no longer started from a normal THOR binary but | ||
| has its own binary that you can find in ``tools/thunderstorm`` or | ||
| ``tools\thunderstorm.exe``. See :ref:`deployment/thunderstorm:Thunderstorm Deployment` for | ||
| more information. |
There was a problem hiding this comment.
verified. But why is there a thunderstorm.exe (that cannot run on Windows) in my tools folder then? @secDre4mer
obsoletes #206 as it had the wrong merge base