Repository navigation
Add device label to config - #694
Merged
Merged
Conversation
ABuljko
marked this pull request as ready for review
August 12, 2026 20:56
ABuljko
requested review from
daringer,
robin-nitrokey and
sosthene-nitrokey
and removed request for
a team
August 12, 2026 20:56
Member
|
LGTM. Required before merging: |
Author
|
Should I then undo this commit: Temporarily patch admin-app to the config-string branch |
Member
|
We first need to update opcard because it also depends on admin-app, then you can rebase and drop the commit. |
ABuljko
force-pushed
the
device-label
branch
3 times, most recently
from
October 13, 2026 12:16
22019ea to
3c3acec
Compare
Member
|
@ABuljko Can you please change the name to |
- Add an `admin` config namespace with a `label` field, stored as a 32 byte heapless::String - Enable the serde feature of heapless - Raise the limit in test_config_size from 64 to 128 bytes, as a config with a maximum-length label no longer fits into 64
Author
|
@robin-nitrokey Done |
Collaborator
|
No significant changes. Insignifcant changes
|
Author
|
Next on the line is the SDK then :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
globalconfig namespace with adevice_labelfield, stored as a 32 byte heapless::String