Repository navigation
Conversation
…variant Split package into two subpackages for MySQL and PostgreSQL each. The previous `syncstorage-rs` package name points at the MySQL variant for backward compatiblity.
Contributor
Author
|
It’s complaining that I declared the package in |
Member
|
Duplicate of #501943 |
4 of 13 tasks
Contributor
Author
|
Did a review of their version and submitted comments there. I may have missed a thing or two, but most things that are better in mine than theirs should now also be in their review comments: |
nixpkgs-ci
Bot
added
the
2.status: merge conflict
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #484932
This upgrade the
syncstorage-rspackage to new 0.22.1 version and splits its build into a MySQL and (new) PostgreSQL variant. The NixOS module is upgraded to allow the usage for PostgreSQL with a simple option change.Existing NixOS installation will continue to use MySQL, new installations will need to explicitly specify the database backend.
@mweinelt @n0rc
Things done
passthru.tests.nixpkgs-reviewon this PR. See nixpkgs-review usage../result/bin/.