Skip to content

#4439 NERWidget component - #4555

Open
SaraLynnJ wants to merge 15 commits into
feature/bay-dashboardfrom
#4450-bay-dash-url
Open

SaraLynnJ wants to merge 15 commits into
feature/bay-dashboardfrom
#4450-bay-dash-url

Conversation

@SaraLynnJ

@SaraLynnJ SaraLynnJ commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

Changes

Adds the shared NERWidget frame for bay dashboard widgets and uses it in the bay dashboard grid.

Created Widget component for bay dashboard. Includes optional text, children, padding, borders, and three different size options

Screenshots

Screenshot 2026-10-12 at 6 00 49 PM

Checklist

It can be helpful to check the Checks and Files changed tabs.
Please review the contributor guide and reach out to your Tech Lead if anything is unclear.
Please request reviewers and ping on slack only after you've gone through this whole checklist.

  • All commits are tagged with the ticket number
  • No linting errors / newline at end of file warnings
  • All code follows repository-configured prettier formatting
  • No merge conflicts
  • All checks passing
  • Screenshots of UI changes (see Screenshots section)
  • Remove any non-applicable sections of this template
  • Assign the PR to yourself
  • No yarn.lock changes (unless dependencies have changed)
  • Request reviewers & ping on Slack
  • PR is linked to the ticket (fill in the closes line below)

Closes #4439

@SaraLynnJ SaraLynnJ self-assigned this Sep 29, 2026
@cielbellerose
cielbellerose removed the request for review from wavehassman September 29, 2026 20:56
@cielbellerose
cielbellerose changed the base branch from develop to feature/bay-dashboard September 29, 2026 21:07
@cielbellerose

Copy link
Copy Markdown
Contributor

make sure to merge into feature/bay-dashboard for these prs instead of develop

@SaraLynnJ

Copy link
Copy Markdown
Contributor Author

make sure to merge into feature/bay-dashboard for these prs instead of develop

Sorry! Do you want me to make a new pr?

@cielbellerose

Copy link
Copy Markdown
Contributor

make sure to merge into feature/bay-dashboard for these prs instead of develop

Sorry! Do you want me to make a new pr?

No, all good! I updated it at the top. sorry for the delay in reviewing - there are some merging issues that I can fix rq

@cielbellerose cielbellerose mentioned this pull request Sep 30, 2026
11 tasks
@cielbellerose

Copy link
Copy Markdown
Contributor

next time, we want to create a branch from the original ticket, for example working off of branch #4439-bay-dash-nerwidget. It looks like your changes were committed on branch #4450-bay-dash-url which is connected to a different pr that was already merged. I'll also rename this pr to match the issue number and desc

@cielbellerose cielbellerose changed the title #4450 bay dash url #4439 NERWidget component Sep 30, 2026

@cielbellerose cielbellerose left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments, but this looks really great so far! great job

Comment thread src/frontend/src/pages/BayDashboardPage/components/NERWidget.tsx Outdated
Comment thread src/frontend/src/pages/BayDashboardPage/components/NERWidget.tsx Outdated
Comment thread src/frontend/src/pages/BayDashboardPage/components/NERWidget.tsx Outdated
Comment thread src/frontend/src/pages/BayDashboardPage/components/NERWidget.tsx Outdated
Comment thread src/frontend/src/pages/BayDashboardPage/components/NERWidget.tsx Outdated
import { Box } from '@mui/material';
import { Box, Typography } from '@mui/material';

interface NERWidgetProps {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there no size? Shouldn't BayDashboardWidgetSize be a required prop?

Comment thread src/frontend/src/components/NERWidget.tsx

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bay Dashboard] - NERWidget Component

3 participants