ci: point inactive issuers at software Ed25519 - #28
Merged
Conversation
The synthetic decision workflow now checks qualification_software_ed25519.py. It stays refuse-closed: activation_state is inactive, signer_registry is null, and the job still exits 1. No secrets, no environment, no KMS, no OIDC. Add the missing issue-production-release-admission.yml that qualification_issuer.py already names. Same inactive refuse path until a signer registry exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The synthetic decision issuer on main still called
qualification_kms_ed25519.py interfaceand told the operator to wait for KMS/OIDC. That script never talks to AWS, but the workflow contract was the KMS one. This PR points that job atqualification_software_ed25519.pyinstead.evidence-registry.jsonstill hassigner_registry: null. Flippingactivation_stateto active now would try to issue without a registry, so the job stays refuse-closed: it checks inactive, checks the registry is absent, andexit 1. Nosecrets., noenvironment:, no OIDC. When a later change publishes a registry and flips the interface, the same secret name (OPENADAPT_QUALIFICATION_ED25519_PRIVATE_KEY) is the one the software signer already uses via--from-env.qualification_issuer.pyalready stamps.github/workflows/issue-production-release-admission.ymlon every release admission. That file was missing. This adds it as the same inactive refuse path asissue-qualification-admission.yml.Reviewer checks:
python3 -m unittest discover -s tests -p 'test_*.py'(248 tests).qualification_software_ed25519.pyand does not containqualification_kms_ed25519.py.secrets., noenvironment:, and noaws kms.evidence-registry.jsonis untouched.This does not admit Flow. The issuer stays inactive.
Opened by an agent session, not the founder.