fix: count remote-safe-synthetic Flow as an active target admission - #32
Merged
Conversation
A qualification-release/v2 row with evidence_class remote-safe-synthetic is a real package admission for that target. Put it in active[target_id]. One row is not seven-target Production and does not flip MockMed production_acceptance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Flow 1.34.0
qualification-release/v2row isevidence_class: remote-safe-synthetic. After #31 the validator accepted that row, then skipped it when fillingactive, so it printed0 active admission(s)andcheck_profile.pykept Flow as not admitted.That skip is gone. A synthetic package admission now lands in
active[target_id].validate_production_lifecycle.pyreports 1 active admission.is_product_production(active)stays false until all seven targets are inactive. It doesn't flip MockMedproduction_acceptance.This repo has no builder that copies
activeintolatest_admission. The in-repo consumer ischeck_profile.py, which copiesactiveinto the per-target table inREPOSITORY_LIFECYCLE.md. Flow is Production there now. The public JSON at docs.openadapt.ai/production-lifecycle.json is rendered in openadapt-ops; pin that renderer after this merges.Reviewer: run
python3 -m unittest discover -s tests -p 'test_*.py'. Then runpython3 scripts/validate_production_lifecycle.pyand look for1 active admission(s).Opened by an agent session, not the founder.