fix: wait for a quiet frame tree before keeping a secret-masked screenshot - #465
Open
abrichr wants to merge 2 commits into
Open
fix: wait for a quiet frame tree before keeping a secret-masked screenshot#465abrichr wants to merge 2 commits into
abrichr wants to merge 2 commits into
Conversation
…nshot Three immediate retries lost to SPA login pages that attach and detach iframes after Sign in. Retry until the tree is still, up to eight seconds. Discard every PNG taken while frames moved. Still refuse if it never settles. Opened by an agent session, not the founder.
A fake login page attaches and detaches iframes for the old three-try budget, then goes quiet. That is the ServiceNow Sign-in failure. The record must keep a masked frame. A tree that never settles still refuses. Opened by an agent session, not the founder.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Secret-masked screenshots (
--secret password) refused the ServiceNow PDI wake record. The login page attached and detached iframes after Sign in. Three immediate retries all saw a moving frame tree.The backend now retries until the frame tree is still, for up to 8 seconds. It still discards any PNG taken while frames moved. It still refuses if the tree never settles.
Verification
pytest tests/test_browser_attach.py::test_live_cdp_attach_records_compiles_and_leaves_browser_running_three_trialspassed (82s). Persistent churn still raises. Churn that then settles keeps a masked frame.Opened by an agent session, not the founder.