fix: keep until-revoked admissions across policy-file revisions - #211
Merged
Conversation
A later until-revoked policy hash must not un-admit retained rows. Object-reference inventory rows are not product targets.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The docs twin of
validateLiveAdmissionsfail-closes the same way as openadapt-web. Live admissions keep the v1policy_sha256. Policy rev 7 has a different file hash. Until-revoked rows then get dropped even thoughexpires_atis JSON null.Object-ref rows (
kind: "qualification-release", no.target) hit the samebyTarget.has(admission.target)check. They are the evidence inventory, not a seventh product target.What changed
Same contract as the web change:
policy_sha256to equal the current policy file hash when policy isuntil_revoked,expires_atis JSON null, the row is not revoked, and the admissions digest still matches the pin.Evidence class stays
remote-safe-synthetic. No new unsigned ledger row.Opened by an agent session, not the founder.