Global assistant: Forward attachments to Apollo - #5096
Open
hanna-paasivirta wants to merge 4 commits into
Open
Conversation
hanna-paasivirta
marked this pull request as ready for review
August 26, 2026 17:00
Security Review ✅
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Global chat ignored the "Send logs" and "Send scrubbed I/O" checkboxes. The UI said the data was attached; nothing was sent to Apollo. This wires it up.
Changes
attachmentslist to Apollo: run logs, scrubbed step input, scrubbed step outputjob_id,step_idandlevelso Apollo can tell which job a line came fromNot in scope
:access_writeand:access_readresolve to plain project membership), so global chat now matches job chat rather than changing thatjob_chatlog attachment, and this PR does not attempt to fix them. Some seem triggered by editing the workflow after running it. I did not notice these issues in this new global assistant attachment implementation.Safety
global_chat_streamwas touched in the Apollo clientmainCloses #5093
Validation steps
You can test with Apollo on
main, although this could surface very occasional lost attachments when forwarding the query to a subagent (fixed onsubagent-contextOpenFn/apollo#649)job_chatimplementation, there seem to be bugs around edited workflows, possibly unsaved workflows, or which jobs/steps logs relate to.AI Usage
Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):
You can read more details in our
Responsible AI Policy
Pre-submission checklist
/reviewwith Claude Code)
(e.g.,
:owner,:admin,:editor,:viewer)