Repository navigation

Fix FLOPS Nacelle dimensions to ensure correct scaling with Engine.SCALE_FACTOR - #1314

Open

cmbenne3 wants to merge 27 commits into

OpenMDAO:mainfrom

cmbenne3:issue1281

Commits on Sep 24, 2026
- add new nacelle reference length variables
  Bennett
  committed
  e06c8e9
Commits on Sep 25, 2026
- update characteristic lengths component to calculte scaled Nacelle Dimensions
  Bennett
  committed
  f2bac35
- removing engine scale factor from nacelle wetted area calculation
  Bennett
  committed
  bac2363
- add additional test to test_characteristic_lengths
  Bennett
  committed
  192ba9d
- update nacelle test to remove engine scaling which is no longer in this component
  Bennett
  committed
  77fffc4
- update nacelle reference values in test data, reorder subsystems in prep_geom to avoid feedback loops
  Bennett
  committed
  f6fedc5
- further updates to validation data to add calculated nacelle dimensions as inputs as well as outputs
  Bennett
  committed
  7089075
- updating csv files to use the new refererence variables
  Bennett
  committed
  6f4073e
- alphabetisation
  Bennett
  committed
  c7df525
- update combined geometry to include selective override capability for nacelle variables that are calculated by both FLOPS and GASP pre mission geometry subsystems
  Bennett
  committed
  28bb3e5
- Merge branch 'main' into issue1281
  cmbenne3
  authored
  59fa6c7
- remove commented lines from test_nacelle
  Bennett
  committed
  6a2a38b
- clean up characteristic lengths by removing calculation of Engine.SCALE_FACTOR, this variable is now an input to the Nacelle calculations replacing the scaled and reference SLS thrust variables
  Bennett
  committed
  9000f74
- update test_prep_geom to use Engine.SCALE_FACTOR instead of SLS variables, and add useful geometry outputs to the geometry report
  Bennett
  committed
  179a6a7
- adding landing gear outputs to geometry report
  Bennett
  committed
  0f93880
- fix typo in geometry report
  Bennett
  committed
  087c892
- final tweaks to geometry subsystem report
  Bennett
  committed
  61e6bd0
- Merge branch 'main' into issue1281
  cmbenne3
  authored
  1cd4f6e
- Merge branch 'main' into issue1281
  cmbenne3
  authored
  964ec9d
Commits on Oct 5, 2026
- Merge branch 'OpenMDAO:main' into issue1281
  cmbenne3
  authored
  87fa7fd
- adding preprocessor deprecations function
  Bennett
  committed
  c8b8547
- adding preprocessors deprecation warning and creating nacelle_prelim to scale nacelle independently from calculating characteristic lengths
  Bennett
  committed
  f39675e
- update tests to reflect new structure of nacelle prelim and characteristic lengths
  Bennett
  committed
  f5c31ff
Commits on Oct 6, 2026
- update characteristic length tests and combined geometry paths
  Bennett
  committed
  b313102
Commits on Oct 7, 2026
- Merge branch 'OpenMDAO:main' into issue1281
  cmbenne3
  authored
  c18e229
Commits on Oct 9, 2026
- Merge branch 'main' into issue1281
  cmbenne3
  authored
  0b8e70c
- update throttle allocation test to have correct values now that nacelles are scaling correctly
  cmbenne3
  committed
  f979e7d

Navigation Menu

Repository navigation

Fix FLOPS Nacelle dimensions to ensure correct scaling with Engine.SCALE_FACTOR - #1314

Fix FLOPS Nacelle dimensions to ensure correct scaling with Engine.SCALE_FACTOR#1314
cmbenne3 wants to merge 27 commits into
OpenMDAO:mainfrom
cmbenne3:issue1281

Commits on Sep 24, 2026

add new nacelle reference length variables

Commits on Sep 25, 2026

update characteristic lengths component to calculte scaled Nacelle Dimensions

removing engine scale factor from nacelle wetted area calculation

add additional test to test_characteristic_lengths

update nacelle test to remove engine scaling which is no longer in this component

update nacelle reference values in test data, reorder subsystems in prep_geom to avoid feedback loops

further updates to validation data to add calculated nacelle dimensions as inputs as well as outputs

updating csv files to use the new refererence variables

alphabetisation

update combined geometry to include selective override capability for nacelle variables that are calculated by both FLOPS and GASP pre mission geometry subsystems

Merge branch 'main' into issue1281

remove commented lines from test_nacelle

clean up characteristic lengths by removing calculation of Engine.SCALE_FACTOR, this variable is now an input to the Nacelle calculations replacing the scaled and reference SLS thrust variables

update test_prep_geom to use Engine.SCALE_FACTOR instead of SLS variables, and add useful geometry outputs to the geometry report

adding landing gear outputs to geometry report

fix typo in geometry report

final tweaks to geometry subsystem report

Merge branch 'main' into issue1281

Merge branch 'main' into issue1281

Commits on Oct 5, 2026

Merge branch 'OpenMDAO:main' into issue1281

adding preprocessor deprecations function

adding preprocessors deprecation warning and creating nacelle_prelim to scale nacelle independently from calculating characteristic lengths

update tests to reflect new structure of nacelle prelim and characteristic lengths

Commits on Oct 6, 2026

update characteristic length tests and combined geometry paths

Commits on Oct 7, 2026

Merge branch 'OpenMDAO:main' into issue1281

Commits on Oct 9, 2026

Merge branch 'main' into issue1281

update throttle allocation test to have correct values now that nacelles are scaling correctly