feat: implement color and shape leaf hit testing - #1066
Conversation
|
👀 Human review needed JustificationThis PR implements new functional hit-testing and geometry logic in the core event/render path — it is not a docs, formatting, or otherwise mechanical change, so it falls outside automatic low-risk approval. Key factors:
Static analysis only; build and tests are owned by CI. Reviewed commit e7536da |
| guard points.contains(where: { framedShape.frame.contains($0) }) else { | ||
| return BitVector64() | ||
| } | ||
| return path.contains( |
There was a problem hiding this comment.
This new shape hit-test path calls Path.contains(points:eoFill:origin:), but that overload still ends in _openSwiftUIUnimplementedFailure(). Any hit test whose point is inside a path-backed shape's frame will now trigger a precondition failure instead of returning a containment mask.
Severity: high
🤖 Was this useful? React with 👍 or 👎
🛠️ Tuist Run Report 🛠️Tests 🧪
Builds 🔨
|
🤖 Augment PR SummarySummary: This PR implements hit testing for color and shape-backed leaf views. Changes:
Technical Notes: The changes make hit-testing masks operate on transformed local point buffers and use the existing responder-helper invalidation flow. 🤖 Was this summary useful? React with 👍 or 👎 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1066 +/- ##
==========================================
- Coverage 29.92% 29.90% -0.03%
==========================================
Files 790 790
Lines 62423 62483 +60
==========================================
+ Hits 18682 18685 +3
- Misses 43741 43798 +57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
e7536da to
7d3326e
Compare
Summary
ColorViewhit testing and description attributes.ShapeStyledLeafViewhit testing, content paths, and responder updates with clear-style handling and background selection.PlatformPointbuffers across content responders and forward thePathpoint-array overload to its buffer overload.Validation
Focused, isolated behavior checks passed for color containment and shape responder forwarding.