Skip to content

fix(identity): correct seed allocation and restore IdentityLink - #1093

Merged
Kyle-Ye merged 2 commits into
mainfrom
bugfix/identity_link
Sep 24, 2026
Merged

Kyle-Ye merged 2 commits into
mainfrom
bugfix/identity_link

Conversation

@Kyle-Ye

@Kyle-Ye Kyle-Ye commented Sep 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Advance identity seeds correctly and wrap from UInt32.max to 1, preserving 0 as invalid.
  • Restore IdentityLink initialization and property-wrapper reads, rejecting reads before installation.
  • Add tests for distinct identities, seed overflow, and invalid reads.

@github-actions github-actions Bot added area: view View APIs, modifiers, AnyView, ForEach, DynamicView, and related behavior. type: bug Something is not working correctly. type: tests Test coverage, test infrastructure, snapshots, or test-only changes. labels Sep 24, 2026
@codecov

codecov Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.12%. Comparing base (f47dd57) to head (61977d9).

Files with missing lines Patch % Lines
Sources/OpenSwiftUI/View/IdentityLink.swift 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1093      +/-   ##
==========================================
+ Coverage   33.10%   33.12%   +0.01%     
==========================================
  Files         803      803              
  Lines       63662    63667       +5     
==========================================
+ Hits        21077    21090      +13     
+ Misses      42585    42577       -8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tuist

tuist Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

🛠️ Tuist Run Report 🛠️

Tests 🧪

Scheme Status Test modules Commit
OpenSwiftUI ✅ 7 7ca4c3dd3

Builds 🔨

Scheme Status Duration Commit
OpenSwiftUI ✅ 41.2s 7ca4c3dd3

@Kyle-Ye
Kyle-Ye merged commit ba72504 into main Sep 24, 2026
6 checks passed
@Kyle-Ye
Kyle-Ye deleted the bugfix/identity_link branch September 24, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: view View APIs, modifiers, AnyView, ForEach, DynamicView, and related behavior. type: bug Something is not working correctly. type: tests Test coverage, test infrastructure, snapshots, or test-only changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant